Feat/replay merged#3
Merged
Merged
Conversation
…nSerializer + records
…jects to JacksonSerializer + records
…unishment type conversion
Drops the abstract PartyEvent hierarchy (29 subclasses, hand-rolled JSONObject serializers per class, findFromType reflection switch with dummy instances) in favour of two sealed interfaces of records: PartyAction for server->service commands and PartyBroadcast for service->server notifications. Wire format is plain Jackson polymorphism via @JsonSubTypes, so the push protocol carries the typed event itself instead of (eventType, eventData) strings. Endpoint and broadcast handler dispatch via exhaustive sealed-switch - adding a new variant is a compile error in two places, not a silent runtime failure. Collapses the 8 near-identical Typed*PartyEventHandler files (~2700 lines, 95% duplication) into a single PartyBroadcastHandler in type.generic, auto-registered for every server type. SkyBlock-specific warp branding is preserved via HypixelConst.getTypeLoader().getType().isSkyBlock(). Net: -5199 / +236 lines. BREAKING CHANGE: removes net.swofty.commons.party.PartyEvent, PartyResponseEvent and the events/ + events/response/ subpackages, PartyEventPushProtocol, SendPartyEventToServiceProtocolObject. Replaced by PartyAction, PartyBroadcast, PartyBroadcastPushProtocol, SendPartyActionProtocolObject. PartyManager public API unchanged.
- Drop SanityTest (per ArikSquad: no value over what JUnit's own smoke tests cover). - Rename AreFriendsMessage(player1, player2) to (player, other) for readability.
…r clash The record component named 'success' auto-generates a boolean success() accessor, which conflicts with a zero-arg static factory of the same name. CI caught it; renamed the factory to ok().
Same record-accessor clash as the Response fix - 'handled' is a record component so the auto-generated handled() accessor collides with a zero-arg static factory of the same name.
Fix SkyblockMob nametags
…denlocation fix: location of spider's den hologram
…ervice-revamp Typed service communication refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.