forked from rust-lang/book
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check that we don't use any unstable features.
We need to track Rust master, but don't want to cover unstable things. As such, a new lint, `stable-check`, is added. The second edition was already lint clean, but the first needed some tweaks: 1. The closures chapter was showing off details of the closure traits, so just don't do that. 2. The FFI chapter was using internal libc to compile the tests, so just don't compile them anymore. 3. The compiler plugins chapter was vestigial and was moved to the unstable book. Fixes rust-lang#558
- Loading branch information
1 parent
dba7772
commit 59f76f1
Showing
7 changed files
with
103 additions
and
294 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
[package] | ||
name = "stable-check" | ||
version = "0.1.0" | ||
authors = ["steveklabnik <steve@steveklabnik.com>"] | ||
|
||
[dependencies] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
use std::env; | ||
use std::fmt; | ||
use std::fs; | ||
use std::fs::File; | ||
use std::io; | ||
use std::io::prelude::*; | ||
use std::path::Path; | ||
|
||
fn main() { | ||
let arg = env::args().nth(1).unwrap_or_else(|| { | ||
println!("Please pass a src directory as the first argument"); | ||
std::process::exit(1); | ||
}); | ||
|
||
match check_directory(&Path::new(&arg)) { | ||
Ok(()) => println!("passed!"), | ||
Err(e) => { | ||
println!("Error: {}", e); | ||
std::process::exit(1); | ||
} | ||
} | ||
|
||
} | ||
|
||
enum Error { | ||
Io(io::Error), | ||
LintFailure(String), | ||
} | ||
|
||
impl From<io::Error> for Error { | ||
fn from(e: io::Error) -> Error { | ||
Error::Io(e) | ||
} | ||
} | ||
|
||
impl From<String> for Error { | ||
fn from(e: String) -> Error { | ||
Error::LintFailure(e) | ||
} | ||
} | ||
|
||
impl fmt::Display for Error { | ||
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
match self { | ||
&Error::Io(ref e) => write!(f, "I/O error: {}", e), | ||
&Error::LintFailure(ref e) => write!(f, "Lint failed: {}", e), | ||
} | ||
} | ||
} | ||
|
||
fn check_directory(dir: &Path) -> Result<(), Error> { | ||
for entry in fs::read_dir(dir)? { | ||
let entry = entry?; | ||
let path = entry.path(); | ||
|
||
if path.is_dir() { | ||
continue; | ||
} | ||
|
||
let mut file = File::open(&path)?; | ||
let mut contents = String::new(); | ||
file.read_to_string(&mut contents)?; | ||
|
||
if contents.contains("#![feature") { | ||
return Err(Error::LintFailure(format!("Feature flag found in {:?}", path))); | ||
} | ||
} | ||
|
||
Ok(()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.