Skip to content

Commit

Permalink
feat: list erroneous rules in results comment (#17)
Browse files Browse the repository at this point in the history
  • Loading branch information
AriPerkkio authored Aug 8, 2021
1 parent cd0d286 commit c45eaab
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
9 changes: 9 additions & 0 deletions src/comment-templates.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import { Result } from 'eslint-remote-tester/dist/exports-for-compare-action';
import { requirePeerDependency } from './peer-dependencies';

const filterUniqueTruthy = <T>(item: T, index: number, array: T[]) =>
item != null && array.indexOf(item) === index;

const formatRule = (rule: string | null) => '\n- `' + rule + '`';

// prettier-ignore
/**
* Template for building github issue comment when action run into error
Expand Down Expand Up @@ -34,6 +39,8 @@ export const COMMENT_TEMPLATE = (
const limitReached = results.length > maxResultCount;
const limitedResults = results.slice(0, maxResultCount);

const rules = results.map(result => result.rule).filter(filterUniqueTruthy);

// prettier-ignore
return '' +
`Detected ${results.length} ESLint reports and/or crashes. ${repositoryCount ? `
Expand All @@ -43,6 +50,8 @@ ${limitReached ?
Reached maximum result count ${maxResultCount}.
Showing ${limitedResults.length}/${results.length}
` : ''}
Rules:${rules.map(formatRule).join('')}
<details>
<summary>Click to expand</summary>
Expand Down
14 changes: 14 additions & 0 deletions test/comment-templates.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ describe('COMMENT_TEMPLATE', () => {
"Detected 2 ESLint reports and/or crashes.
Scanned 152 repositories.
Rules:
- \`rule-1\`
- \`rule-2\`
<details>
<summary>Click to expand</summary>
Expand Down Expand Up @@ -80,6 +84,11 @@ describe('COMMENT_TEMPLATE', () => {
Reached maximum result count 2.
Showing 2/3
Rules:
- \`rule-1\`
- \`rule-2\`
- \`rule-3\`
<details>
<summary>Click to expand</summary>
Expand Down Expand Up @@ -129,6 +138,11 @@ describe('COMMENT_TEMPLATE', () => {
Reached maximum result count 2.
Showing 2/3
Rules:
- \`rule-1\`
- \`rule-2\`
- \`rule-3\`
<details>
<summary>Click to expand</summary>
Expand Down

0 comments on commit c45eaab

Please sign in to comment.