chore(cardinal): log a warning if RegisterSystems encounters a duplicate System name #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerargus
suggested changes
Nov 9, 2023
…f-the-same-system-is-registered
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
+ Coverage 64.63% 64.71% +0.07%
==========================================
Files 82 82
Lines 4660 4670 +10
==========================================
+ Hits 3012 3022 +10
Misses 1318 1318
Partials 330 330
|
technicallyty
changed the title
technicallyty
changed the title
jerargus
approved these changes
Nov 13, 2023
namrapatel
approved these changes
Nov 13, 2023
…f-the-same-system-is-registered
technicallyty
deleted the
tyler/world-529-make-registersystems-error-if-the-same-system-is-registered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
isnt 100% fool-proof as systems that cant get their names through reflection won't be checked.
also renames
ecs's AddSystem(s) to RegisterSystem to align naming.Brief Changelog
Testing and Verifying
unit test in system_test.go