- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2
Extension vs Dashboard Load Balancing #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
nginx config file, command line port option, load balancing header inclusion
…tatic routing on the frontend
| debug_log("Extension routes are enabled") | ||
| else: | ||
| debug_log("Extension routes are disabled") | ||
|  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment: I could see instances where we want to enable/disable a lot more of the Learning Observer routes on the system.
Not sure that it's needed for the first pass, but would be good to think about and toy around with.
| * the data will be sent to. | ||
| */ | ||
| var WEBSOCKET_SERVER_URL = "wss://learning-observer.org/wsapi/in/" | ||
| var WEBSOCKET_SERVER_URL = "wss://learning-observer.org/wsapi/in?source=extension" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really ought to have the url not hardcoded and pulled from a config of some sort, but that's way beyond the scope of this PR and the work you are doing.
Mostly leaving this note to push it to the front of my brain (I'm most likely to work on it)
| Possible bug: PMSS always initializes using the default config file (creds.yaml), and ignores the command line argument  See here | 
| 
 The initialization should probably be moved into the  pmss_settings = None
def load_settings(config):
    '''...'''
    global settings, pmss_settings
    pmss_settings = pmss.init(
        prog=__name__,
        description="A system for monitoring",
        epilog="For more information, see PMSS documentation.",
        rulesets=[pmss.YAMLFileRuleset(filename=config)]
    ) | 
(I accidentally opened a pull request earlier into the ETS repo, disregard that one and use this instead)
Basic frontend and backend implementations of static (extension vs dashboard) routing. Also includes an nginx config, as well as docs for using nginx.
To set whether dashboard and extension routes should be enabled or not, use the following in
creds.yaml:Further, here is a list of places where the dashboard url needs to be modified to support static routing (i.e.
?source=dashboardshould be appended to the end of the url):