Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sending CAN_FORWARD requests when not in CAN UI (CRITICAL BUG) #3417

Closed
tridge opened this issue Sep 24, 2024 · 1 comment
Closed

sending CAN_FORWARD requests when not in CAN UI (CRITICAL BUG) #3417

tridge opened this issue Sep 24, 2024 · 1 comment
Labels
bug

Comments

@tridge
Copy link
Contributor

tridge commented Sep 24, 2024

MissionPlanner is sending CAN_FORWARD requests to the flight controller when not in the CAN UI. This is very nasty and we need to get this behaviour removed quickly.
With ArduPilot 4.5.6 (current stable) this can cause the DroneCAN thread to consume 100% of resources, so that no messages can be sent on any telemetry link. I will be opening a PR soon to address this in ArduPilot.
Even with that change it is still an extremely bad idea to be requesting CAN_FORWARD when the user has not opened the CAN UI. It could completely flood the telemetry link on lower bandwidth radios links to the point that the user loses all situational awareness.
@tridge tridge added the bug label Sep 24, 2024
@tridge
Copy link
Contributor Author

tridge commented Sep 24, 2024

the bug was caused by this PR:
#3299
thanks to @robertlong13 for finding this

@tridge tridge mentioned this issue Sep 24, 2024
Merged
@robertlong13 robertlong13 mentioned this issue Sep 24, 2024
Merged
@tridge tridge closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tridge