Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Confirmation Box for Raw Parameter Setup #3404

Open
prathamEndu opened this issue Sep 11, 2024 · 3 comments
Open

Improved Confirmation Box for Raw Parameter Setup #3404

prathamEndu opened this issue Sep 11, 2024 · 3 comments

Comments

@prathamEndu
Copy link

prathamEndu commented Sep 11, 2024

Issue Details

Enhancement Proposal: Improved Confirmation Box for Raw Parameter Setup

When changing parameters and writing them, the current implementation displays a confirmation dialog box. However, I propose an enhancement to this dialog: it should list all changed parameters, showing both their previous and new values. This would allow users to verify all changes before confirming.

Implementation

I am interested in working on this enhancement myself, if possible. I believe the relevant code may reside in the GCSViews/ConfigurationView/ConfigRawParams.cs file, but I’m not entirely certain.

Any suggestions or guidance on where to start would be greatly appreciated.

@prathamEndu prathamEndu changed the title Improvement in confirmation box for Raw param setup Improved Confirmation Box for Raw Parameter Setup Sep 11, 2024
@prathamEndu
Copy link
Author

I’ve submitted a pull request to address the issue Enhance full parameter change message box #3412. This PR improves the confirmation dialog by displaying all changed parameters along with their previous and new values, enhancing user verification before finalizing changes.

Here is a preview :
updated message box

@jagrandle
Copy link

In your proposal above you said "This would allow users to verify all changes before confirming."

However you only receive this message AFTER you have made the changes. Might it not be a bit superfluous by then ?

@prathamEndu
Copy link
Author

Good point, I have made another commit with added changes in the same PR

The following changed are done in the final commit

In a separate confirmation box for parameter changes :

  1. 0 parameter changes are ignored
  2. 1-20 parameter changes are shown with details (a separate loop is run for collecting these details)
  3. more than 20 parameter changes are shown just as a number

In the saved parameter box :

  1. 0 parameter change message updated
  2. more than 0 parameter change show the count

Preview

existing message box

Fig : existing message box

less than 20 changes

Fig : less than or equal to 20 changes confirmation box

more than 20 changes

Fig : more than 20 changes confirmation box

no param change

Fig : no param change saved box

saved message

Fig : one or more param change saved box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants