Skip to content

Conversation

@lgc2333
Copy link

@lgc2333 lgc2333 commented Feb 24, 2025

Summary by Sourcery

Bug Fixes:

  • Fixes a bug where empty shortcut prefixes were displayed incorrectly.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 24, 2025

Reviewer's Guide by Sourcery

This pull request fixes a bug where empty shortcut prefixes were being displayed in the help text. The fix involves updating the condition that checks for the existence of prefixes before displaying them.

Updated class diagram for InnerShortcutArgs

classDiagram
  class InnerShortcutArgs{
    +prefixes: list[str]
    +fuzzy: bool
    +command: str
    +args: list[Any]
    +origin: Any
  }
  note for InnerShortcutArgs "The prefixes attribute is a list of strings that represent the prefixes for the shortcut."
Loading

File-Level Changes

Change Details Files
Fixed a bug where empty shortcut prefixes were being displayed.
  • Updated the condition to check if any prefixes exist before displaying them.
src/arclet/alconna/formatter.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@RF-Tar-Railt RF-Tar-Railt merged commit 447a5fb into ArcletProject:v1.8 Feb 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants