Community App Store (Sourcery refactored)#184
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if not locked: | ||
| return html.button( | ||
| return ( | ||
| None | ||
| if locked | ||
| else html.button( | ||
| {"className": "btn btn-sm", "onClick": _lock_invite_code}, | ||
| html.span({"className": "glyphicon glyphicon-lock", "aria-hidden": "true"}), | ||
| html.span( | ||
| { | ||
| "className": "glyphicon glyphicon-lock", | ||
| "aria-hidden": "true", | ||
| } | ||
| ), | ||
| ) | ||
|
|
||
| return None | ||
| ) |
There was a problem hiding this comment.
Function lock_invite_code refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| if not isinstance(value, return_type): | ||
| return return_type(value) | ||
| return value | ||
| return value if isinstance(value, return_type) else return_type(value) |
There was a problem hiding this comment.
Function _parse_env_value refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| if _DB_ENGINE in {"MYSQL"}: | ||
| return _DB_ENGINE | ||
|
|
||
| return "SQLITE3" | ||
| return _DB_ENGINE if _DB_ENGINE in {"MYSQL"} else "SQLITE3" |
There was a problem hiding this comment.
Function get_database_engine refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| if auth_level == AuthLevel.admin: | ||
| return staff_required(view) | ||
| return view | ||
| return staff_required(view) if auth_level == AuthLevel.admin else view |
There was a problem hiding this comment.
Function authenticated refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.12%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
sourcery-ai
bot
force-pushed
the
sourcery/app_store
branch
from
410dfee to
bb4e529
Compare
1 participant
Pull Request #69 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
app_storebranch, then run:Help us improve this pull request!