-
Notifications
You must be signed in to change notification settings - Fork 8
Update Java-Client to current network protocol #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The per message deflate looks correct based on looking at the documentation of the org.java_websocket library.
Also removed uncessary assignments of new datapackages
Tested the client as of commit b9aee87 with a local dev branch of StS Mod. Observations:
So overall this PR as it stands seems to work fine for StS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One behavior issue on windows, and a nit. You can disregard the nit if you want.
String appData = System.getenv("LOCALAPPDATA"); | ||
String userHome = System.getProperty("user.home"); | ||
if(appData == null || appData.isEmpty()) { | ||
windowsDataPackageCache = Paths.get(userHome, "appdata","local","Archipelago","cache","datapackage"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On windows the environment variable for user home is USERPROFILE
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this:
String userHome = System.getProperty("user.home")
needs to be this:
String userHome = System.getProperty("USERPROFILE")
Is that right?
Co-authored-by: cjmang <13842799+cjmang@users.noreply.github.com>
LGTM |
Updated
Added