- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
CI: add optional windows release build and build attestation #4940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            black-sliver
  merged 9 commits into
  ArchipelagoMW:main
from
black-sliver:ci/attest-builds
  
      
      
   
  Apr 29, 2025 
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            9 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      9ef5320
              
                CI: github attestation for manually started builds
              
              
                black-sliver f791e67
              
                CI: include appimage zsync in build attestation
              
              
                black-sliver 1bafaf2
              
                CI: github attestation for Linux release builds
              
              
                black-sliver e9b6f4f
              
                CI: reorder steps in build.yml
              
              
                black-sliver 241227f
              
                CI: add windows builds to release.yml
              
              
                black-sliver e6277a5
              
                CI: order jobs in release.yml
              
              
                black-sliver 40df1b6
              
                CI: add missing permission to release.yml
              
              
                black-sliver dbf8b2a
              
                CI: enable windows build in release.yml
              
              
                black-sliver 80bec0e
              
                CI: false is skip
              
              
                black-sliver File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see us making commits just to flip this, in all likelihood we'd just delete the unsighed build and replace it with a signed one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna leave it in just in case