Skip to content

Stardew Valley: Replace event creation stardew code with add_event #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

Stardew Valley: Replace event creation stardew code with add_event #4922

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e060c43
replace event creation stardew code with add_event
Jouramie Apr 25, 2025
40a0e84
delete unnecessary default args
Jouramie Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions worlds/stardew_valley/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,17 +299,9 @@ def create_item(self, item: str | ItemData, override_classification: ItemClassif

return StardewItem(item.name, override_classification, item.code, self.player)

def create_event_location(self, location_data: LocationData, rule: StardewRule = None, item: Optional[str] = None):
if rule is None:
rule = True_()
if item is None:
item = location_data.name

def create_event_location(self, location_data: LocationData, rule: StardewRule, item: str):
region = self.multiworld.get_region(location_data.region, self.player)
location = StardewLocation(self.player, location_data.name, None, region)
location.access_rule = rule
region.locations.append(location)
location.place_locked_item(StardewItem(item, ItemClassification.progression, None, self.player))
region.add_event(location_data.name, item, rule, StardewLocation, StardewItem)

def set_rules(self):
set_rules(self)
Expand Down
Loading