Skip to content

Conversation

@remyjette
Copy link
Collaborator

What is this fixing or adding?

Pre-KivyMD the server connect bar would be pre-populated with the last server the user had connected to (via self.ctx.suggested_address) or archipelago.gg: if that was empty.

Post-KivyMD, the server connect bar is always blank.

I tried setting text manually instead of via the constructor, and it works now.

How was this tested?

Launched CommonClient.py. Saw my last server in the connect bar. Connected to that, then disconnected and connected to a different server. Closed and relaunched the client, saw the second server now populated in the connect bar.

If this makes graphical changes, please attach screenshots.

Fresh launch of CommonClient.py:

image

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 18, 2025
Copy link
Contributor

@Rooby-Roo Rooby-Roo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not fluent enough in Kivy/MD to know exactly why this change fixes things, but I was able to replicate this and confirm that it now works.

This should be labeled as a bugfix, I think.

@remyjette remyjette added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 18, 2025
@remyjette
Copy link
Collaborator Author

From Silvris in the discord:

Ah, so that works but there's a better fix
I waited to PR to see if we were gonna need another bulk fix PR like the last two
Basically I fucked up the kwargs on ResizableTextField so none of them are being handled

I'm still going to leave this PR up until/unless the better fix PR is created and merged, since we should have at least some fix go in before the next release.

@remyjette
Copy link
Collaborator Author

#4903 merged and is a better fix, closing

@remyjette remyjette closed this Apr 19, 2025
@remyjette remyjette deleted the kivymd-connect-address branch April 19, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants