Pokemon Red/Blue: Convert to Procedure Patch #4801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
remyjette
added
is: enhancement
I own Pokemon Blue. Tested. Did not require a ROM for generation, it created a .apblue in the output zip. Resulting .apblue was able to patch, connect, send an item, receive an item. |
Alchav
approved these changes
Apr 4, 2025
Zunawe
removed
the
waiting-on: world-maintainer
qwint
reviewed
Apr 11, 2025
qwint
reviewed
Apr 11, 2025
qwint
reviewed
Apr 12, 2025
qwint
approved these changes
Apr 12, 2025
Zunawe
added
waiting-on: core-review
Berserker66
approved these changes
Apr 30, 2025
19 tasks
FlitPix
pushed a commit
to FlitPix/Archipelago
that referenced
this pull request
Jun 4, 2025
(cherry picked from commit 227f0bc)
ProfDeCube
pushed a commit
to ProfDeCube/Archipelago
that referenced
this pull request
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Converts Pokemon Red/Blue to use
APProcedurePatchso it can generate without needing a ROM. This is largely a sort of manual find and replace. There are some times that the original code looped over a sequence and replaced each byte manually. Those mostly were swapped for a single token containing the whole sequence. And there were some additional cleanup changes, some typing, and replacing single-quoted strings with double-quoted strings.How was this tested?
Generated a couple hundred 2-player games with Eijebong's fuzzer. Stole about a dozen of those randomly generated yamls to generate a set of patch files on
mainand a set of patch files on this branch using the same seed. Patched them all, and then compared the hashes of the resulting ROMs.Based on the testing, it creates the same resulting ROM byte for byte, which also means the RNG calls are the same.
Only tested for Pokemon Red; I don't own Pokemon Blue.