Skip to content

Stardew Valley: Use new asserts in tests #4621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Aug 31, 2025
Merged

Stardew Valley: Use new asserts in tests #4621

merged 31 commits into from
Aug 31, 2025

Conversation

@Jouramie
Copy link
Contributor

@Jouramie Jouramie commented Feb 8, 2025 •
edited
Loading

What is this fixing or adding?

This takes a bunch of changes that I originally made in #4239, and adapts them for the new asserts #4556.

How was this tested?

Yes

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 8, 2025
agilbert1412
agilbert1412 approved these changes Feb 8, 2025
View reviewed changes
Copy link
Collaborator

@agilbert1412 agilbert1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions, but overall, good PR, great improvements, lots of boilerplate removal, I'd absolutely take it as-is

@Exempt-Medic Exempt-Medic added the is: refactor/cleanup Improvements to code/output readability or organizization. label Feb 8, 2025
Jouramie added a commit to agilbert1412/Archipelago that referenced this pull request Feb 16, 2025
@Jouramie
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
d285837
Jouramie added a commit to agilbert1412/Archipelago that referenced this pull request Mar 24, 2025
@Jouramie
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
b0b9fc5
@Jouramie Jouramie mentioned this pull request Apr 9, 2025
Merged
Jouramie added a commit to agilbert1412/Archipelago that referenced this pull request Apr 21, 2025
@Jouramie
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
6e6dca8
@nicholassaylor
Copy link
Contributor

This now has conflicts btw

Jouramie added a commit to agilbert1412/Archipelago that referenced this pull request May 17, 2025
@Jouramie
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
a2a574e
Jouramie added a commit to agilbert1412/Archipelago that referenced this pull request May 17, 2025
@Jouramie
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
63abdba
Jouramie added a commit to agilbert1412/Archipelago that referenced this pull request May 17, 2025
@Jouramie
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
c160bba
duckboycool
duckboycool approved these changes May 18, 2025
View reviewed changes
Copy link
Contributor

@duckboycool duckboycool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense, there's just a typing change that I think should also be added to other places it was used.

nicholassaylor
nicholassaylor approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@qwint qwint added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 21, 2025
Jouramie added a commit to agilbert1412/Archipelago that referenced this pull request May 24, 2025
@Jouramie
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
2f50434
Jouramie added a commit to agilbert1412/Archipelago that referenced this pull request May 24, 2025
@Jouramie
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
765a004
Jouramie added a commit to agilbert1412/Archipelago that referenced this pull request Jun 27, 2025
@Jouramie
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
f4abd7d
Jouramie added a commit to agilbert1412/Archipelago that referenced this pull request Jul 19, 2025
@Jouramie
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
5080557
Berserker66
Berserker66 reviewed Jul 26, 2025
View reviewed changes
Jouramie added a commit to agilbert1412/Archipelago that referenced this pull request Aug 12, 2025
@Jouramie
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
780db27
NewSoupVi
NewSoupVi requested changes Aug 30, 2025
View reviewed changes
Copy link
Member

@NewSoupVi NewSoupVi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question, otherwise this looks good

@Jouramie Jouramie requested a review from NewSoupVi August 31, 2025 13:49
@NewSoupVi NewSoupVi merged commit cdf7165 into ArchipelagoMW:main Aug 31, 2025
16 checks passed
@Jouramie Jouramie deleted the StardewValley/use-new-asserts-in-tests branch August 31, 2025 14:22
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Sep 10, 2025
@Jouramie @agilbert1412
Stardew Valley: Use new asserts in tests (ArchipelagoMW#4621)
c3b2614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Berserker66 Berserker66 Berserker66 left review comments

@NewSoupVi NewSoupVi NewSoupVi approved these changes

+3 more reviewers

@agilbert1412 agilbert1412 agilbert1412 approved these changes

@duckboycool duckboycool duckboycool approved these changes

@nicholassaylor nicholassaylor nicholassaylor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Jouramie @nicholassaylor @Berserker66 @agilbert1412 @duckboycool @NewSoupVi @qwint @Exempt-Medic