Skip to content

Conversation

@Alchav
Copy link
Contributor

@Alchav Alchav commented Dec 3, 2024

What is this fixing or adding?

Allows games with all items linked to generate. Stores an item outside the item pool to place into the Player's PC, as this location cannot have a non-local item in it for technical reasons. The rest of the usual "forced local" items allow item linked items for the player, though this defeats the purpose of forcing them to be local items.

How was this tested?

Generated with a default yaml + "Everything" item linked. Ran the #2081 test, SMZ3 reported failure but not Pokémon R/B.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Dec 3, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Dec 3, 2024
Exempt-Medic
Exempt-Medic previously approved these changes Dec 3, 2024
Copy link
Contributor

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment that probably doesn't need to be addressed. Otherwise the changes seem fine, tested various configurations locally and they worked.

@Alchav Alchav marked this pull request as draft December 4, 2024 00:14
@Alchav Alchav marked this pull request as ready for review December 5, 2024 19:13
@Exempt-Medic Exempt-Medic added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Dec 29, 2024
Copy link
Collaborator

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to init look good, tested a simple item link (with skip output so did not play) with mostly default settings locally, did not review regions.py changes past the section affecting world.pc_item, but from a skim the rest just looks like reorganization

@Exempt-Medic
Copy link
Contributor

changes to init look good, tested a simple item link (with skip output so did not play) with mostly default settings locally, did not review regions.py changes past the section affecting world.pc_item, but from a skim the rest just looks like reorganization

Yeah the regions.py changes need to be reverted

@Exempt-Medic Exempt-Medic dismissed their stale review January 12, 2025 23:53

Waiting on regions.py update

@Exempt-Medic
Copy link
Contributor

You reverted all the file changes btw

@Exempt-Medic
Copy link
Contributor

@Alchav Reminder about this PR

@Exempt-Medic Exempt-Medic merged commit 7f35eb8 into ArchipelagoMW:main Mar 16, 2025
16 checks passed
Witchybun pushed a commit to Witchybun/Archipelago that referenced this pull request May 29, 2025
* Pokémon R/B: Allow generating with all items linked

* check priority/excluded locations for pc_item

* Update regions.py

* Un-remove regions.py code
ProfDeCube pushed a commit to ProfDeCube/Archipelago that referenced this pull request Jun 13, 2025
* Pokémon R/B: Allow generating with all items linked

* check priority/excluded locations for pc_item

* Update regions.py

* Un-remove regions.py code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants