- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
Pokémon R/B: Allow generating with all items linked #4330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment that probably doesn't need to be addressed. Otherwise the changes seem fine, tested various configurations locally and they worked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to init look good, tested a simple item link (with skip output so did not play) with mostly default settings locally, did not review regions.py changes past the section affecting world.pc_item, but from a skim the rest just looks like reorganization
| 
 Yeah the  | 
| You reverted all the file changes btw | 
| @Alchav Reminder about this PR | 
* Pokémon R/B: Allow generating with all items linked * check priority/excluded locations for pc_item * Update regions.py * Un-remove regions.py code
* Pokémon R/B: Allow generating with all items linked * check priority/excluded locations for pc_item * Update regions.py * Un-remove regions.py code
What is this fixing or adding?
Allows games with all items linked to generate. Stores an item outside the item pool to place into the Player's PC, as this location cannot have a non-local item in it for technical reasons. The rest of the usual "forced local" items allow item linked items for the player, though this defeats the purpose of forcing them to be local items.
How was this tested?
Generated with a default yaml + "Everything" item linked. Ran the #2081 test, SMZ3 reported failure but not Pokémon R/B.