Skip to content

OoT Adjuster: Remove per_slot_randoms #4264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 19, 2025
Merged

OoT Adjuster: Remove per_slot_randoms #4264

merged 7 commits into from
Jan 19, 2025

Conversation

@nicholassaylor
Copy link
Contributor

What is this fixing or adding?

Remove use of per_slot_randoms in the OoT Adjuster by changing it to the world's random
Addresses #3382 (comment)

How was this tested?

It was not

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Nov 27, 2024
@alwaysintreble
Copy link
Collaborator

Not tested, but looking at what it's doing here I think this line can just be straight up removed. Before we had per_world_random, per_slot_randoms was set in set_seed, which is skipped here, but it's initialized in the world constructor now. Random import can likely also be removed

@nicholassaylor
Copy link
Contributor Author

Not tested, but looking at what it's doing here I think this line can just be straight up removed. Before we had per_world_random, per_slot_randoms was set in set_seed, which is skipped here, but it's initialized in the world constructor now. Random import can likely also be removed

On second look, I would agree

@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. is: refactor/cleanup Improvements to code/output readability or organizization. labels Nov 27, 2024
alwaysintreble
alwaysintreble approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@alwaysintreble alwaysintreble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not tested but looks correct

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jan 19, 2025
@Exempt-Medic Exempt-Medic merged commit cbf4bbb into ArchipelagoMW:main Jan 19, 2025
16 checks passed
@nicholassaylor nicholassaylor deleted the oot-adjuster-randoms branch January 19, 2025 23:23
Witchybun pushed a commit to Witchybun/Archipelago that referenced this pull request May 29, 2025
@nicholassaylor @Witchybun
OoT Adjuster: Remove per_slot_randoms (ArchipelagoMW#4264)
03a246f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@alwaysintreble alwaysintreble alwaysintreble approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicholassaylor @alwaysintreble @Exempt-Medic