Core: Refactor URL parser to support multi-game clients #4133
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
|
This has some overlap with #3905, but doesn't involve any breaking changes |
This is what 3905 does, so I'll do the same
Exempt-Medic
added
the
is: enhancement
# Conflicts: # worlds/LauncherComponents.py # worlds/_bizhawk/context.py
benny-dreamly
approved these changes
Sep 10, 2025
Berserker66
added
waiting-on: author
|
Has conflicts by now. |
# Conflicts: # Launcher.py # worlds/LauncherComponents.py # worlds/_bizhawk/client.py # worlds/_bizhawk/context.py
|
Conflicts have been resolved |
ScipioWright
added
waiting-on: peer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The way #2779 was implemented, it didn't account for Client Components that handle more than one game name, such as the Manual and Bizhawk clients.
This refactors the code to support an array of names, and adds URL support to BizhawkClient.
How was this tested?
Launching the launcher with a URL with
?game=Pokemon Red and BlueIf this makes graphical changes, please attach screenshots.