SMZ3: fix item links with link_replacement

[Silvris]

What is this fixing or adding?

Worlds are expected to be able to have get_filler_item_name called without any fill steps being performed. SMZ3 is relying on self.junkItemNames, which doesn't exist until create_items. This just adds a set of defaults for the list that still gets replaced during create_items.

How was this tested?

Generated a two-player SMZ3 with the following item link.

  item_links:
    # Share part of your item pool with other players.
    - name: All
      item_pool:
        - Everything
      replacement_item: null
      link_replacement: true

On current main, this will fail with an AttributeError.

If this makes graphical changes, please attach screenshots.

[Silvris]

@lordlou

[qwint]

confirmed on the item link test branch that this makes smz3 pass said test

[Exempt-Medic]

Code LGTM, tested through manually using itemlinks. The selection of items also makes sense, since it's every junk item except the ones that might cause problems in excess numbers (Heart Piece, Bomb Upgrade, Arrow Upgrade)

[NewSoupVi]

Re-pinging @lordlou. This issue is quite important to us as it is blocking a unit test.
Will probably do a ping in the Discord on Monday, and then potentially just merge this if no response

[lordlou]

Pre-filling junkItemsNames looks good to me but why is ItemType.HeartPiece, ItemType.ArrowUpgrade5 and ItemType.BombUpgrade5 missing?

[Exempt-Medic]

Pre-filling junkItemsNames looks good to me but why is ItemType.HeartPiece, ItemType.ArrowUpgrade5 and ItemType.BombUpgrade5 missing?

Can they cause problems if you have too many?
If they can't though then it is a bit weird that they're missing. I guess they do have more permanent effects than the rest

[lordlou]

Oh I missed your previous comment already stating the reason. I agree with you. All good then :)