Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Make an actual LogicMixin spec & explanation #3975

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Docs: Make an actual LogicMixin spec & explanation #3975

wants to merge 18 commits into from
+73 −3

Conversation

NewSoupVi
Copy link
Member

No description provided.

@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 21, 2024
Exempt-Medic
Exempt-Medic suggested changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments

docs/world api.md Outdated Show resolved Hide resolved
docs/world api.md Outdated Show resolved Hide resolved
NewSoupVi and others added 2 commits September 21, 2024 19:13
@NewSoupVi @Exempt-Medic
Update docs/world api.md
7b097c9 
Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com>
@NewSoupVi
Update docs/world api.md
555b721
Exempt-Medic
Exempt-Medic approved these changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ScipioWright
ScipioWright approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but also you told me about it in the first place so

docs/world api.md Outdated Show resolved Hide resolved
@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 24, 2024
NewSoupVi and others added 3 commits September 25, 2024 13:13
@NewSoupVi @ScipioWright
Update docs/world api.md
c21c10a 
Co-authored-by: Scipio Wright <scipiowright@gmail.com>
@NewSoupVi
Update world api.md
e694804
@NewSoupVi
Update world api.md
c0cd03f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScipioWright ScipioWright ScipioWright approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NewSoupVi @ScipioWright @Exempt-Medic