New Game Implementation: Civilization VI

[hesto2]

What is this fixing or adding?

Support for Civilization VI as a new world.

How was this tested?

The world has several test suites as well as running it through alpha & beta with the community since May

[ScipioWright]

These are mainly suggestions, feel free to agree, disagree, or discuss any of them with me as desired.

[hesto2]

@ScipioWright thank you for the review 🙏

[ScipioWright]

Just a few other things while I have a moment

[ScipioWright]

I did some test gens with a yaml (renamed to weights.yaml so the host.yaml players can affect it) with most options set to random.

I found that if shuffle_goody_hut_rewards is on and the other options are set to random, it'll fail almost every time with a 50-player game.

I found that with it off, a 20-player game generation slows way way way down during item placement. Usually this means swap is having a hard time but hasn't outright failed, usually due to a small amount of sphere 1 locations.
It's hard to say for sure without debugging.

[hesto2]

Oh interesting, I'll take a look. So I can make sure I'm debugging correctly, were these all civ games or was the 20/50 a mix?

…

On Mon, Sep 9, 2024, 7:39 AM Scipio Wright ***@***.***> wrote: I did some test gens with a yaml (renamed to weights.yaml so the host.yaml players can affect it) with most options set to random. I found that if shuffle_goody_hut_rewards is on and the other options are set to random, it'll fail almost every time with a 50-player game. I found that with it off, a 20-player game generation slows way way way down during item placement. Usually this means swap is having a hard time but hasn't outright failed, usually due to a small amount of sphere 1 locations. It's hard to say for sure without debugging. — Reply to this email directly, view it on GitHub <#3736 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2A4K5XUS4ED7WLBKZU6RTZVWQHNAVCNFSM6AAAAABMBPDZBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZYGE2TKNRZHA> . You are receiving this because you commented.Message ID: ***@***.***>

[ScipioWright]

All Civ games

[hesto2]

I did some test gens with a yaml (renamed to weights.yaml so the host.yaml players can affect it) with most options set to random.

I found that if shuffle_goody_hut_rewards is on and the other options are set to random, it'll fail almost every time with a 50-player game.

I found that with it off, a 20-player game generation slows way way way down during item placement. Usually this means swap is having a hard time but hasn't outright failed, usually due to a small amount of sphere 1 locations. It's hard to say for sure without debugging.

Ok I think I'm going to take a pass at how the rules are setup for some of the earlier stages and refactor that a bit. It looks like it is just a little too restrictive for it to successfully gen with larger numbers of player and I think there's probably some optimizations I can add in that will make it go faster

[hesto2]

I did some test gens with a yaml (renamed to weights.yaml so the host.yaml players can affect it) with most options set to random.

I found that if shuffle_goody_hut_rewards is on and the other options are set to random, it'll fail almost every time with a 50-player game.

I found that with it off, a 20-player game generation slows way way way down during item placement. Usually this means swap is having a hard time but hasn't outright failed, usually due to a small amount of sphere 1 locations. It's hard to say for sure without debugging.

Ok I got this working MUCH better, I was able to generate with a large amount of players 20, 50, 50+ and the generation times were all 30-60 seconds (previously 600+ seconds, and closer to 1000 for some of those ones that stalled out).

I had to give the randomizer some help with figuring out how to fill the first few locations (I denied late game items for the first era and forced all the items required to pass the first era to be early_items). Solid catch with this, I'll definitely keep this in my pocket as a test case for this and my Metroid apworld

[hesto2]

@ScipioWright (sorry for the ping) Anything else I can look at, or any other sets of eyes you'd recommend I get on this?