sc2: Fixing typo in itemgroups.py causing spurious item groups #3612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… letters chopped off
github-actions
bot
added
the
waiting-on: peer-review
remyjette
approved these changes
Jul 3, 2024
remyjette
added
is: bug/fix
Ziktofel
approved these changes
Jul 3, 2024
ScipioWright
added
waiting-on: core-review
NewSoupVi
approved these changes
Jul 5, 2024
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
… letters chopped off (ArchipelagoMW#3612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixing spurious item groups created by a typo.
Note this is already fixed in the sc2-next beta, looks like we just forgot to port the fix back to main.
How was this tested?
Put a temporary printout of all item group names, verified "Abili", "Un", etc didn't appear in the list.
If this makes graphical changes, please attach screenshots.
None