LADX: Moved ROM requirement from generate_output to stage_assert_generate. #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
hatkirby
approved these changes
Jun 15, 2024
NewSoupVi
approved these changes
Jun 16, 2024
ScipioWright
added
the
is: bug/fix
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…rate. (ArchipelagoMW#3540) Co-authored-by: Mrks <markus.burmeister@mburm.de>
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…rate. (ArchipelagoMW#3540) Co-authored-by: Mrks <markus.burmeister@mburm.de>
GameWyrm
pushed a commit
to GameWyrm/Archipelago-GW
that referenced
this pull request
Jul 4, 2024
…rate. (ArchipelagoMW#3540) Co-authored-by: Mrks <markus.burmeister@mburm.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
LADX was requesting the ROM for the output in generate_output. This leads to some issues while generating. Now this part is moved to stage_assert_generate like it is done i.e. in ALttP and DKC3.
How was this tested?
Removed any ROMs from the dev folder. Generated locally and observed that the ROM request comes in the same step like SMW.
If this makes graphical changes, please attach screenshots.
Console shows that the ROM request is now similar to other games.
