Allow worlds to add options to prebuilt groups #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this crashed because `typing.NamedTuple` fields such as `group.name` aren't assignable. Now it will only fail for group names that are actually incorrectly cased, and will fail with a better error message.
github-actions
bot
added
affects: core
| @@ -123,8 +123,8 @@ def __new__(mcs, name: str, bases: Tuple[type, ...], dct: Dict[str, Any]) -> Web | |||
| assert group.options, "A custom defined Option Group must contain at least one Option." | |||
| # catch incorrectly titled versions of the prebuilt groups so they don't create extra groups | |||
| title_name = group.name.title() | |||
| if title_name in prebuilt_options: | |||
| group.name = title_name | |||
| assert title_name not in prebuilt_options or title_name == group.name, \ | |||
There was a problem hiding this comment.
i'm fine with the assert title_name == group.name since i was on the fence about whether that should exist but the other bool here is wrong and the if immediately after this will now not be hit ever.
There was a problem hiding this comment.
i thought that was an and, not an or 🤦
alwaysintreble
approved these changes
Jun 11, 2024
Exempt-Medic
approved these changes
Jun 11, 2024
Exempt-Medic
added
is: bug/fix
NewSoupVi
approved these changes
Jun 12, 2024
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
Previously, this crashed because `typing.NamedTuple` fields such as `group.name` aren't assignable. Now it will only fail for group names that are actually incorrectly cased, and will fail with a better error message.
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
Previously, this crashed because `typing.NamedTuple` fields such as `group.name` aren't assignable. Now it will only fail for group names that are actually incorrectly cased, and will fail with a better error message.
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
Previously, this crashed because `typing.NamedTuple` fields such as `group.name` aren't assignable. Now it will only fail for group names that are actually incorrectly cased, and will fail with a better error message.
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Previously, this crashed because `typing.NamedTuple` fields such as `group.name` aren't assignable. Now it will only fail for group names that are actually incorrectly cased, and will fail with a better error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Previously, this crashed because
typing.NamedTuplefields such asgroup.namearen't assignable. Now it will only fail for group namesthat are actually incorrectly cased, and will fail with a better error
message.
How was this tested?
I updated the DS3 beta to add options to a prebuilt group.