The Witness: Fix Shuffle Postgame always thinking it's Challenge Victory #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewSoupVi
added
affects: release/blocker
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
approved these changes
Jun 9, 2024
NewSoupVi
added
waiting-on: core-review
|
Putting on core review because it's 1 line change + moving 1 block of code |
Berserker66
approved these changes
Jun 15, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…ory (ArchipelagoMW#3504) * Fix postgame thinking it's the wrong panel * Also don't have a default value for it so it doesn't happen again
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…ory (ArchipelagoMW#3504) * Fix postgame thinking it's the wrong panel * Also don't have a default value for it so it doesn't happen again
GameWyrm
pushed a commit
to GameWyrm/Archipelago-GW
that referenced
this pull request
Jul 4, 2024
…ory (ArchipelagoMW#3504) * Fix postgame thinking it's the wrong panel * Also don't have a default value for it so it doesn't happen again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last reworking of automatic postgame, I changed some stuff about how the victory location is dealt with in postgame.
There is a pretty major bug with it.
handle_postgameuses the victory location before it is actually set, so it just uses the default value every time, always acting like it's Challenge Victory.This makes
shuffle_postgamejust not work correctly at all.Considering this a blocker because a whole option just doesn't work and results in people having locations in their seed they don't want.
My base unit tests PR is not merged yet so I can't add a unit test for this yet, but I can make that property not have a default value, so it errors when it's not set