Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: don't lock progression #3501

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Core: don't lock progression #3501

merged 1 commit into from
Jun 12, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

In #3261 a mark_for_locking callback crept in on prog fill on accident.

How was this tested?

It was not, though it is a revert to something that was tested.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 9, 2024
@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jun 9, 2024
@NewSoupVi NewSoupVi added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 11, 2024
@Exempt-Medic Exempt-Medic added the affects: release/blocker Issues/PRs that must be addressed before next official release. label Jun 12, 2024
@Berserker66 Berserker66 merged commit 2daccde into main Jun 12, 2024
28 checks passed
@Berserker66 Berserker66 deleted the core_no_lock_progression branch June 12, 2024 13:35
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Jun 13, 2024
@Berserker66 @agilbert1412
Core: don't lock progression (ArchipelagoMW#3501)
89a864a
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@Berserker66
Core: don't lock progression (ArchipelagoMW#3501)
7bb568d
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@Berserker66 @sflavelle
Core: don't lock progression (ArchipelagoMW#3501)
b9d1d2c
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@Berserker66 @qwint
Core: don't lock progression (ArchipelagoMW#3501)
d26cbef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouramie Jouramie Jouramie approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@Alchav Alchav Alchav approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Berserker66 @Jouramie @NewSoupVi @Alchav @Exempt-Medic