Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TUNIC: Fix chest in incorrect region, incorrect key requirement #3132

Merged
merged 3 commits into from
Apr 15, 2024
Merged

TUNIC: Fix chest in incorrect region, incorrect key requirement #3132

merged 3 commits into from
Apr 15, 2024

Conversation

ScipioWright
Copy link
Collaborator

@ScipioWright ScipioWright commented Apr 12, 2024 •
edited
Loading

What is this fixing or adding?

Fixes the region for a chest which should be in After Ruined Passage instead of Above Ruined Passage.
Also fixed the little locked house in Atoll requiring 1 key instead of 2 (they're consumable, but I don't think anyone ever uses one at the Ruined Passage so it's never really mattered until now).

How was this tested?

Test gens

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 12, 2024
@ScipioWright ScipioWright added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 12, 2024
@ScipioWright ScipioWright changed the title TUNIC: Fix chest in incorrect region TUNIC: Fix chest in incorrect region, incorrect key requirement Apr 14, 2024
Ixrec
Ixrec approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@Ixrec Ixrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change matches my understanding of what the logic should be for these chests after playing Tunic rando several times (and discovering one of the bugs being fixed here)

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. affects: release/blocker Issues/PRs that must be addressed before next official release. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 14, 2024
@ThePhar ThePhar merged commit 6dbeb6c into ArchipelagoMW:main Apr 15, 2024
15 checks passed
@ScipioWright ScipioWright deleted the patch-3 branch April 15, 2024 02:21
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@ScipioWright @EmilyV99
TUNIC: Fix chest in incorrect region, incorrect key requirement (Arch…
7a9883e 
…ipelagoMW#3132)
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@ScipioWright @EmilyV99
TUNIC: Fix chest in incorrect region, incorrect key requirement (Arch…
abc7ec7 
…ipelagoMW#3132)
@patrickwhite256 patrickwhite256 mentioned this pull request Apr 15, 2024
Merged
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@ScipioWright @qwint
TUNIC: Fix chest in incorrect region, incorrect key requirement (Arch…
2e53600 
…ipelagoMW#3132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ixrec Ixrec Ixrec approved these changes

@ThePhar ThePhar ThePhar approved these changes

@silent-destroyer silent-destroyer silent-destroyer approved these changes

Assignees
No one assigned
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScipioWright @Ixrec @ThePhar @silent-destroyer