SNIClient: Let clients based on SNIClient monitor packages via on_package method #3093
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Exempt-Medic
added
the
is: enhancement
beauxq
reviewed
Apr 5, 2024
Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
qwint
approved these changes
Jul 27, 2024
This was referenced Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds the ability for worlds using SNIClient to monitor/handle packages via the
on_packagemethod in their client code.How was this tested?
Edited my (WIP) MMX3 world to listen to
Connected,SetReplyandRetrievedpackages withEnergyLinkas their keys (if applicable) to monitor EnergyLink updates and modify a label accordingly, label got updated so it worked fine. The image below shows the label being up to date with the latest deposit which can be seen on the client lines.Also tested SMW and ALTTP if their clients broke with my changes and they didn't. Worked fine.
If this makes graphical changes, please attach screenshots.