Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUNIC: Revise ER path hints to be more generous #2847

Closed
wants to merge 9 commits into from

Conversation

ScipioWright
Copy link
Collaborator

@ScipioWright ScipioWright commented Feb 19, 2024

What is this fixing or adding?

From a recommendation by alwaysintreble, uses all state to generate hint paths to locations in ER. All state appears to have short paths to checks most of the time, so it's decently appropriate to use here.

This also just completely removes the old hinting thing we had going on, and good riddance imo.

How was this tested?

Several gens, hinting everything and looking for anything weird

If this makes graphical changes, please attach screenshots.

image

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 19, 2024
@ScipioWright ScipioWright added the is: enhancement Issues requesting new features or pull requests implementing new features. label Feb 19, 2024
@ScipioWright ScipioWright added the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Feb 20, 2024
@ScipioWright ScipioWright removed the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Feb 20, 2024
@benny-dreamly
Copy link
Contributor

I read the code and it doesn't look bad. I didn't test it however.

@ScipioWright ScipioWright marked this pull request as draft February 20, 2024 21:47
@github-actions github-actions bot removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 20, 2024
@ScipioWright
Copy link
Collaborator Author

Drafting until I can sit down and add names to the ladder storage entrances

@ScipioWright ScipioWright marked this pull request as ready for review February 21, 2024 02:23
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 21, 2024
@ScipioWright
Copy link
Collaborator Author

ScipioWright commented Feb 21, 2024

Alright, it is now ready again. Unique entrance names have been added to the ladder storage entrances, and those identifiers get stripped out when making the entrance hints since they're not helpful there. Also refactored how the ladder storage entrances are made since there was a lot of duplication there.

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 21, 2024
@ScipioWright ScipioWright marked this pull request as draft February 21, 2024 16:11
@ScipioWright ScipioWright removed the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 21, 2024
@ScipioWright
Copy link
Collaborator Author

I thought of a way to make it a little more efficient, going to work through and check if it works and if it does actually make it more efficient.

@ScipioWright
Copy link
Collaborator Author

Other method didn't end up being faster, just harder to read.

@ScipioWright ScipioWright marked this pull request as ready for review February 21, 2024 16:25
@ScipioWright ScipioWright added the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 21, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 21, 2024
@ScipioWright ScipioWright removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 21, 2024
@ScipioWright
Copy link
Collaborator Author

Going to have to close this since it not being merged is heavily blocking a much bigger PR for a new feature setting. Going to just combine it into that new one so I don't have to juggle conflicts like a crazy person.

@github-actions github-actions bot removed the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Mar 2, 2024
@ScipioWright ScipioWright deleted the tunic-er-hints branch May 3, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants