CI: add missing core files to "affects: core" labelling #2824
Conversation
github-actions
bot
added
the
waiting-on: peer-review
|
Should probably be |
|
Agreed with sliver, better to glob it. As for testing, it's pretty cursed to test this, for the initial pr I tested on my fork by pr'ing onto the branch with the workflows. act might be usable here but I have not gotten in deep enough with it to know for sure https://github.com/nektos/act |
|
One additional thought, I wonder if we should disable sync-labels on the workflow - it could be better to leave some space for manual corrections at least while this is in the early stages |
Not sure. We didn't really run into any issues yet, I think? Imo it should be a separate PR if we want to change that, so merging this now as is. |
github-actions
bot
removed
the
waiting-on: peer-review
…W#2824) * add missing files * Change to wildcard
…W#2824) * add missing files * Change to wildcard
…W#2824) * add missing files * Change to wildcard
…W#2824) * add missing files * Change to wildcard
What is this fixing or adding?
#2536 lost the "affects: core" tag after resolving conflicts, as the conflicts removed the changes to
Patch.py, leaving the labeller to see the edits toworlds/Files.pyand decide it wasn't core enough.How was this tested?
Wasn't. Not actually aware of how Github CI can be tested.
If this makes graphical changes, please attach screenshots.