fixes #3391

[ExtReMLapin]

fixes #3391

Checklist

• I have run the build using mvn clean package command
• My unit tests cover both failure and success scenarios

[gemini-code-assist]

Summary of Changes

Hello @ExtReMLapin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the JSON serialization process for database query results, specifically when dealing with projected data. The changes ensure that results containing projected fields are accurately converted into JSON format, preventing data integrity issues and improving the reliability of data output.

Highlights

• Fix for Projection Serialization: Introduced a specific serialization path within JsonSerializer to correctly handle database results that include a _projectionName metadata field. This ensures that projected fields are properly serialized into JSON.
• Explicit Property Handling: When a projection is detected, the code now explicitly iterates through all document properties, serializing each value individually before adding it to the JSON object. This prevents potential issues where projected fields might be missed or incorrectly serialized by the default logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• engine/src/main/java/com/arcadedb/serializer/JsonSerializer.java
  • Added conditional logic in serializeResult to check for _projectionName metadata.
  • Implemented explicit iteration and serialization of document properties for projected results.

Activity

• The pull request is titled 'fixes Cypher : Studio serializer works fine but "normal" one doesn't return the data in the correct field. #3267 all over again #3391', indicating it resolves a reported issue.
• The author has marked the 'I have run the build using mvn clean package command' checklist item as complete.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for c1d914b.

🟢 All jobs passed!

But CI Insights is watching 👀

[gemini-code-assist]

Code Review

This pull request introduces a fix for serializing projected results by adding a special path in JsonSerializer.serializeResult. The change correctly handles results with _projectionName metadata by iterating through the document's map representation and serializing each property.

My review includes a couple of suggestions to improve code style and conciseness.

Most importantly, the checklist in the pull request description indicates that unit tests have not been added for these changes. Given this is a bug fix, it's critical to add a regression test to JsonSerializerTest.java to cover this specific scenario with projections. This will prevent future regressions and validate the fix.

[lvca]

@ExtReMLapin that's great, thanks!