Skip to content

Conversation

@robfrank
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @robfrank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the core Gremlin dependency to version 3.8.0. This update involves necessary code adjustments to accommodate changes introduced in the new TinkerPop version, particularly concerning error handling for type comparisons and the behavior of arithmetic operations like sum() when dealing with long overflows. The changes ensure compatibility and leverage the latest features and fixes from the Gremlin framework.

Highlights

  • Dependency Upgrade: The Gremlin dependency has been updated from version 3.7.4 to 3.8.0 in the pom.xml.
  • GremlinValueComparator Adaptations: The GremlinValueComparator class was modified to align with changes in TinkerPop 3.8.0. This includes replacing GremlinTypeErrorException with IllegalStateException for type comparison errors and making the comparable utility method public to allow access from TinkerPop's Compare class.
  • Test Case Update for Long Overflow Behavior: The GremlinTest.java file was updated to reflect a behavioral change in TinkerPop 3.8.0. Specifically, the longOverflow test now asserts that Long.MAX_VALUE + 1 in sum() operations throws an ArithmeticException (due to overflow) instead of implicitly promoting to BigInteger.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify
Copy link
Contributor

mergify bot commented Jan 22, 2026

🧪 CI Insights

Here's what we observed from your CI run for 767f85e.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Gremlin dependency from version 3.7.4 to 3.8.0. The changes in the codebase are adaptations to breaking changes introduced in the new version, such as replacing GremlinTypeErrorException with IllegalStateException and updating a test for a change in long overflow behavior. The modifications appear correct and necessary for the dependency upgrade. I have one suggestion to improve code clarity in an exception handler.

@codacy-production
Copy link

codacy-production bot commented Jan 22, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.13% 50.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b738fda) 103748 57106 55.04%
Head commit (767f85e) 103748 (+0) 56969 (-137) 54.91% (-0.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3209) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

dependabot bot and others added 2 commits January 23, 2026 00:23
Bumps `gremlin.version` from 3.7.4 to 3.8.0.

Updates `org.apache.tinkerpop:gremlin-core` from 3.7.4 to 3.8.0
- [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc)
- [Commits](apache/tinkerpop@3.7.4...3.8.0)

Updates `org.apache.tinkerpop:gremlin-server` from 3.7.4 to 3.8.0
- [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc)
- [Commits](apache/tinkerpop@3.7.4...3.8.0)

Updates `org.apache.tinkerpop:gremlin-driver` from 3.7.4 to 3.8.0
- [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc)
- [Commits](apache/tinkerpop@3.7.4...3.8.0)

Updates `org.apache.tinkerpop:gremlin-util` from 3.7.4 to 3.8.0
- [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc)
- [Commits](apache/tinkerpop@3.7.4...3.8.0)

Updates `org.apache.tinkerpop:gremlin-groovy` from 3.7.4 to 3.8.0
- [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc)
- [Commits](apache/tinkerpop@3.7.4...3.8.0)

Updates `org.apache.tinkerpop:gremlin-test` from 3.7.4 to 3.8.0
- [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc)
- [Commits](apache/tinkerpop@3.7.4...3.8.0)

---
updated-dependencies:
- dependency-name: org.apache.tinkerpop:gremlin-core
  dependency-version: 3.8.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.tinkerpop:gremlin-server
  dependency-version: 3.8.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.tinkerpop:gremlin-driver
  dependency-version: 3.8.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.tinkerpop:gremlin-util
  dependency-version: 3.8.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.tinkerpop:gremlin-groovy
  dependency-version: 3.8.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.tinkerpop:gremlin-test
  dependency-version: 3.8.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
This commit fixes compatibility issues with TinkerPop 3.8.0:

1. **GremlinValueComparator.comparable()**: Changed visibility from private to public
   - TinkerPop 3.8.0 Compare class requires public access to this method
   - Replaced removed GremlinTypeErrorException with IllegalStateException
   - Updated throwTypeError() method to use standard exception

2. **GremlinTest.testLongOverflow()**: Updated test expectations
   - TinkerPop 3.8.0 changed behavior: now throws ArithmeticException on long overflow
   - Previous versions promoted Long to BigInteger automatically
   - Test now expects ArithmeticException for overflow scenarios
   - Added AssertJ assertThatThrownBy import

These changes ensure full compatibility with Apache TinkerPop 3.8.0 while
maintaining ArcadeDB's performance optimizations for type comparisons.

Related: #2808

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@robfrank robfrank force-pushed the dependabot/maven/gremlin.version-3.8.0 branch from 1129f75 to 767f85e Compare January 22, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant