-
-
Notifications
You must be signed in to change notification settings - Fork 90
chore(deps): bump gremlin.version from 3.7.4 to 3.8.0 #3209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @robfrank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the core Gremlin dependency to version 3.8.0. This update involves necessary code adjustments to accommodate changes introduced in the new TinkerPop version, particularly concerning error handling for type comparisons and the behavior of arithmetic operations like Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🧪 CI InsightsHere's what we observed from your CI run for 767f85e. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Gremlin dependency from version 3.7.4 to 3.8.0. The changes in the codebase are adaptations to breaking changes introduced in the new version, such as replacing GremlinTypeErrorException with IllegalStateException and updating a test for a change in long overflow behavior. The modifications appear correct and necessary for the dependency upgrade. I have one suggestion to improve code clarity in an exception handler.
gremlin/src/main/java/org/apache/tinkerpop/gremlin/util/GremlinValueComparator.java
Show resolved
Hide resolved
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Bumps `gremlin.version` from 3.7.4 to 3.8.0. Updates `org.apache.tinkerpop:gremlin-core` from 3.7.4 to 3.8.0 - [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc) - [Commits](apache/tinkerpop@3.7.4...3.8.0) Updates `org.apache.tinkerpop:gremlin-server` from 3.7.4 to 3.8.0 - [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc) - [Commits](apache/tinkerpop@3.7.4...3.8.0) Updates `org.apache.tinkerpop:gremlin-driver` from 3.7.4 to 3.8.0 - [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc) - [Commits](apache/tinkerpop@3.7.4...3.8.0) Updates `org.apache.tinkerpop:gremlin-util` from 3.7.4 to 3.8.0 - [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc) - [Commits](apache/tinkerpop@3.7.4...3.8.0) Updates `org.apache.tinkerpop:gremlin-groovy` from 3.7.4 to 3.8.0 - [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc) - [Commits](apache/tinkerpop@3.7.4...3.8.0) Updates `org.apache.tinkerpop:gremlin-test` from 3.7.4 to 3.8.0 - [Changelog](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc) - [Commits](apache/tinkerpop@3.7.4...3.8.0) --- updated-dependencies: - dependency-name: org.apache.tinkerpop:gremlin-core dependency-version: 3.8.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.tinkerpop:gremlin-server dependency-version: 3.8.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.tinkerpop:gremlin-driver dependency-version: 3.8.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.tinkerpop:gremlin-util dependency-version: 3.8.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.tinkerpop:gremlin-groovy dependency-version: 3.8.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.tinkerpop:gremlin-test dependency-version: 3.8.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
This commit fixes compatibility issues with TinkerPop 3.8.0: 1. **GremlinValueComparator.comparable()**: Changed visibility from private to public - TinkerPop 3.8.0 Compare class requires public access to this method - Replaced removed GremlinTypeErrorException with IllegalStateException - Updated throwTypeError() method to use standard exception 2. **GremlinTest.testLongOverflow()**: Updated test expectations - TinkerPop 3.8.0 changed behavior: now throws ArithmeticException on long overflow - Previous versions promoted Long to BigInteger automatically - Test now expects ArithmeticException for overflow scenarios - Added AssertJ assertThatThrownBy import These changes ensure full compatibility with Apache TinkerPop 3.8.0 while maintaining ArcadeDB's performance optimizations for type comparisons. Related: #2808 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1129f75 to
767f85e
Compare
No description provided.