Revert "chore(deps): bump gremlin.version from 3.7.4 to 3.8.0"

[robfrank]

Reverts #2808

[gemini-code-assist]

Summary of Changes

Hello @robfrank, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a full revert of a previous dependency upgrade for Gremlin, rolling back the version from 3.8.0 to 3.7.4. This action addresses potential compatibility issues or unexpected behavior introduced by the newer Gremlin version, ensuring the stability and correct functioning of the system's Gremlin integration by restoring the previously stable version.

Highlights

• Dependency Reversion: The Gremlin dependency has been reverted from version 3.8.0 back to 3.7.4 in the pom.xml.
• GremlinValueComparator Logic: Changes related to exception handling and method visibility within GremlinValueComparator.java have been rolled back to align with Gremlin 3.7.4 behavior, specifically changing GremlinTypeErrorException back to IllegalStateException and making the comparable method private again.
• Test Case Adjustment: The longOverflow test in GremlinTest.java has been reverted to its state prior to the 3.8.0 update, no longer expecting an ArithmeticException for long overflow scenarios.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for 66ccd96.

🟢 All jobs passed!

But CI Insights is watching 👀

[gemini-code-assist]

Code Review

This pull request reverts the Gremlin version from 3.8.0 back to 3.7.4. The changes correctly revert the dependency version in pom.xml and adjust the code in GremlinValueComparator.java and GremlinTest.java to be compatible with version 3.7.4. My main feedback is a minor style suggestion in one of the test files to improve code clarity.

[gemini-code-assist]

According to common Java style guides, such as the Google Java Style Guide, using wildcard imports is discouraged. They can obscure which classes are actually used, leading to less readable code and potential naming conflicts. It's better to use explicit imports for improved clarity and maintainability. Please consider using specific class imports instead.

Suggested change

	import java.io.*;
	import java.math.*;
	import java.util.*;
	import java.io.File;
	import java.math.BigInteger;
	import java.util.List;
	import java.util.Map;
	import java.util.Optional;
	import java.util.Set;
	import java.util.UUID;

References

1. The Google Java Style Guide (section 3.3.1) states that wildcard imports, static or otherwise, are not to be used. This is to improve clarity and avoid potential naming collisions. ^(link)

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.11%	✅ 50.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (18177c7)	103451	56795	54.90%
Head commit (66ccd96)	103451 (+0)	56677 (-118)	54.79% (-0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#3190)	2	1	50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences