Skip to content

Conversation

@robfrank
Copy link
Collaborator

@robfrank robfrank commented Dec 6, 2025

This pull request updates the test dependencies and refactors test imports across multiple modules to improve consistency and maintainability. The main change is replacing the use of arcadedb-server (with test-jar type) with the new arcadedb-test-utils artifact for test scopes. Additionally, all test classes now import helper utilities from the com.arcadedb.test package instead of com.arcadedb.server, ensuring a cleaner separation between production and test code.

Dependency updates:

  • Switched test dependency from arcadedb-server to arcadedb-test-utils in pom.xml files for console, graphql, gremlin, and grpc-client modules, removing the type specification for test jars. [1] [2] [3] [4]

Test code refactoring:

  • Updated all test imports to use com.arcadedb.test.* classes (such as TestServerHelper and BaseGraphServerTest) instead of their previous locations in com.arcadedb.server.* across test files in console, gremlin, and grpc-client modules. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]

Console test improvements:

  • Updated references to the default test password in ConsoleAsyncInsertTest to use the new static import from com.arcadedb.test.StaticBaseServerTest. [1] [2]

@robfrank robfrank linked an issue Dec 6, 2025 that may be closed by this pull request
4 tasks
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @robfrank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the consistency and maintainability of the project's test suite by introducing a dedicated test-utils module. This change centralizes common testing infrastructure, reducing redundant dependencies and clarifying the distinction between core server components and test-specific code. The refactoring ensures that test helper classes are sourced from a single, well-defined location, which will simplify future test development and dependency management across various sub-modules.

Highlights

  • New Test Utilities Module: A new Maven module, arcadedb-test-utils, has been created to centralize common test utilities and helpers, promoting better organization and reusability of test code.
  • Dependency Refactoring: The arcadedb-server test dependency has been replaced with the new arcadedb-test-utils artifact across multiple pom.xml files (console, graphql, gremlin, grpc-client, grpcw, metrics, mongodbw, postgresw, redisw), removing the need for the test-jar type specification.
  • Test Import Standardization: All test classes in various modules (console, gremlin, grpc-client, metrics, mongodbw, postgresw, redisw) now import helper utilities from the com.arcadedb.test package instead of com.arcadedb.server, ensuring a clearer separation between production and test code.
  • Server Module Test-Jar Exclusion: The server module's pom.xml has been updated to explicitly disable test-jar packaging, aligning with the new approach of centralizing test utilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2025

🧪 CI Insights

Here's what we observed from your CI run for 5bd7a26.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively refactors the test dependencies by introducing a new test-utils module and centralizing test helper classes. The changes are consistent across the codebase, replacing the arcadedb-server test-jar with the new arcadedb-test-utils artifact, which improves modularity and maintainability.

I've identified a few areas for improvement, mainly within the newly added utility classes. These include resource management, logging practices, and dependency versioning. I also found a critical issue in GloVeTest.java regarding a hardcoded file path that affects test portability. Please see my detailed comments for suggestions.

public class GloVeTest {
private final static int PARALLEL_LEVEL = 8;
private static final String FILE_NAME = "/Users/luca/Downloads/glove.twitter.27B.100d.txt";
private static final String FILE_NAME = "/Users/frank/Downloads/glove.twitter.27B/glove.twitter.27B.100d.txt";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This hardcoded absolute file path makes the test non-portable and will cause it to fail on any machine where the file doesn't exist at this exact location. Please consider moving the test file to the project's resources and loading it from there, or implementing a mechanism to download it if it's not present.

@codacy-production
Copy link

codacy-production bot commented Dec 6, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.24%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (915942a) 70181 45728 65.16%
Head commit (5bd7a26) 70181 (+0) 45557 (-171) 64.91% (-0.24%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2885) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@robfrank robfrank merged commit 9b05a8e into main Dec 7, 2025
18 of 22 checks passed
@robfrank robfrank deleted the feature/2865-create-test-utils-module branch December 7, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TASK-P1-003: Create Test Utils Module

2 participants