Skip to content

use JSON.stringify for deployment.json #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use JSON.stringify for deployment.json #2

wants to merge 1 commit into from
+9 −8

Conversation

frolic
Copy link

@frolic frolic commented Feb 9, 2024

I tried to keep the original formatting (tabs for indentation, empty line at the end of the file) for consistency.

@frolic frolic changed the title use JSON.stringify instead of manual string construction use JSON.stringify for deployment.json Feb 9, 2024
@Jeab111
Copy link

Jeab111 commented Jun 21, 2025 •
edited
Loading

This is the first time I have a approval

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: M66rr @.***>

Sent: Friday, April 18, 2025 7:14:22 PM

To: Arachnid/deterministic-deployment-proxy @.***>

Cc: ALANthemoor @.>; Comment @.>

Subject: Re: [Arachnid/deterministic-deployment-proxy] use JSON.stringify for deployment.json (PR #2)

@M66rr approved this pull request.

—

Reply to this email directly, view it on GitHub#2 (review), or unsubscribehttps://github.com/notifications/unsubscribe-auth/BJG2XHKF5TX55XTWFIC7RJD22GWP5AVCNFSM6AAAAABRCDEUC2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONZZG44DGMRUHE.

You are receiving this because you commented.Message ID: @.***>

@Jeab111
Copy link

Jeab111 commented Jun 21, 2025

I approved it

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: M66rr @.***>

Sent: Monday, April 21, 2025 6:51:08 AM

To: Arachnid/deterministic-deployment-proxy @.***>

Cc: ALANthemoor @.>; Comment @.>

Subject: Re: [Arachnid/deterministic-deployment-proxy] use JSON.stringify for deployment.json (PR #2)

@M66rr approved this pull request.

—

Reply to this email directly, view it on GitHub#2 (review), or unsubscribehttps://github.com/notifications/unsubscribe-auth/BJG2XHL3BYQVZZLII67XM5T22TZUZAVCNFSM6AAAAABRCDEUC2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOBRGI4DINRWGY.

You are receiving this because you commented.Message ID: @.***>

@Jeab111
Copy link

Jeab111 commented Jun 21, 2025

I approved it

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: M66rr @.***>

Sent: Monday, April 21, 2025 6:51:08 AM

To: Arachnid/deterministic-deployment-proxy @.***>

Cc: ALANthemoor @.>; Comment @.>

Subject: Re: [Arachnid/deterministic-deployment-proxy] use JSON.stringify for deployment.json (PR #2)

@M66rr approved this pull request.

—

Reply to this email directly, view it on GitHub#2 (review), or unsubscribehttps://github.com/notifications/unsubscribe-auth/BJG2XHL3BYQVZZLII67XM5T22TZUZAVCNFSM6AAAAABRCDEUC2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOBRGI4DINRWGY.

You are receiving this because you commented.Message ID: @.***>

crypto3699
crypto3699 approved these changes Oct 1, 2025
View reviewed changes
Copy link

@crypto3699 crypto3699 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

crypto3699
crypto3699 approved these changes Oct 1, 2025
View reviewed changes
Copy link

@crypto3699 crypto3699 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock

crypto3699
crypto3699 reviewed Oct 1, 2025
View reviewed changes
Copy link

@crypto3699 crypto3699 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

crypto3699
crypto3699 approved these changes Oct 1, 2025
View reviewed changes
Copy link

@crypto3699 crypto3699 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
6 more reviewers

@09168806659 09168806659 09168806659 approved these changes

@Marco1553 Marco1553 Marco1553 approved these changes

@Boombitchz Boombitchz Boombitchz approved these changes

@DashaBochkar DashaBochkar DashaBochkar approved these changes

@M66rr M66rr M66rr approved these changes

@crypto3699 crypto3699 crypto3699 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@frolic @Jeab111 @09168806659 @Marco1553 @Boombitchz @DashaBochkar @M66rr @crypto3699