Skip to content
This repository was archived by the owner on Feb 19, 2025. It is now read-only.

Fixed Compile Errors #55

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Fixed Compile Errors #55

merged 7 commits into from
Nov 19, 2024

Conversation

hussam-apryse
Copy link
Contributor

  • With vue-cli now in maintenance mode, the scaffolding of the project has been updated to use vite, as recommended by the developers of Vue. This includes changes mentioned by the migration guide
  • vue-cli dependencies and scripts removed and replaced with vite dependencies and scripts
  • Babel and babel.config.js removed in order to provide support for only modern browsers
  • index.html moved to the repo's root.
  • vite SVG files used for icons instead of PNG images
  • process environment variable replaced with the import.meta environment variable used by vite in src/components/WebViewer.vue
  • copy-webviewer-files.js changed to use import as an ES module instead of require as CommonJS
  • With the eslintConfig key in package.json no longer supported in the latest versions of ESLint. Linting in the project was changed to to use a flat eslint.config.mjs config file with the rules mentioned in the CONTRIBUTING.md guide

- Updated Vue scaffolding to use `vite` since `vue-cli` has entered maintenance mode and the developers of Vue recommend using `vite`
- As a result of the above, `index.html` was moved to the repo's root and `vite` SVG files are used for icons.
- Updated linting in the project to use a flat `eslint.config.mjs` config file.
- Added end of Line of License
- Updated PDFTron links to Apryse
Fixed headers in README.md
Use single quotes instead of double quotes as indicated in style guidelines
- Removed spaces from files key which was preventing linting from running properly on VUE files.
- Applied linting rules on VUE files.
Added a rule to ensure files end with a newline (LF)
LICENSE Outdated
Copyright 2024 PDFTron Systems Inc. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to Apryse Software

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Changed "PDFTron" to "Apryse"
@mparizeau-pdftron mparizeau-pdftron merged commit 6027044 into ApryseSDK:master Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants