feat(thumbwheel-tap): expose thumbwheel tap separately#341
Open
MoosaTae wants to merge 1 commit into
Open
Conversation
Greptile SummaryThis PR exposes thumbwheel tap as its own control. The main changes are:
Confidence Score: 5/5This looks safe to merge after checking whether explicit old tap defaults should arm capture.
crates/openlogi-agent-core/src/watchers/gesture.rs Important Files Changed
Reviews (1): Last reviewed commit: "fix: expose thumbwheel tap separately" | Re-trigger Greptile |
| let maps = Arc::new(RwLock::new(hook_runtime::HookMaps::default())); | ||
| assert!(!thumbwheel_armed(&maps, DEFAULT_THUMBWHEEL_SENSITIVITY)); | ||
|
|
||
| maps.write() |
There was a problem hiding this comment.
Explicit Default Starts Capture
When an upgraded config contains an explicit Thumbwheel = AppExpose, this check treats it as non-default because the code default is now None. That arms HID++ thumbwheel diversion even if rotation bindings and sensitivity are unchanged, so a user who only preserved the old tap action can have native thumbwheel scroll captured and re-synthesized unexpectedly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The MX Master 3S reports capacitive tap separately from rotation while the thumbwheel is diverted. OpenLogi hid that tap binding while defaulting it to App Exposé, so rolling and releasing the wheel could trigger App Exposé even when both rotation directions were configured as Do Nothing.
The capture setup also used single-tap support as a prerequisite for all thumbwheel diversion, unintentionally disabling customized rotation on devices without tap support.
User impact
Users can configure rotation and tap independently. Tap is inert by default, while horizontal scrolling remains the default for rotation. Existing explicit tap actions remain intact.
Validation
cargo test -p openlogi-core -p openlogi-hid -p openlogi-agent-core --lib— 180 passedcargo +1.94.0 test -p openlogi-gui— 40 passedcargo fmt --all --checkgit diff --checkRust 1.94 was used for the GUI test and bundle because the current locked
smol_str 0.3.6requires Rust 1.89+, while the local default toolchain is Rust 1.88.Fixes #340