Skip to content

Conversation

@vituri
Copy link

@vituri vituri commented Jun 9, 2025

Changes

Copy code

Closes #134: Create a fork of the extensions repository and move the user.metrics code there:

  1. Copy-pasted the branch main-connect-extension of ConnectUserMetrics to extensions/.

@vituri
Copy link
Author

vituri commented Jun 9, 2025

In the previous PR, Jakub commented:

This PR misses 4 files:
.gitignore
.Rprofile
.rscignore
.renvignore

Those files are also missing in the ConnectUserMetrics. Please add them here and prepare a PR in ConnectUserMetrics repository that fixes the problem.

@vituri vituri marked this pull request as ready for review June 9, 2025 14:47
@vituri
Copy link
Author

vituri commented Jun 9, 2025

@jakubnowicki I created this PR to address your points above.

@vituri
Copy link
Author

vituri commented Jun 10, 2025

@jakubnowicki I copied the main branch again from ConnectUserMetrics here.

@vituri vituri requested a review from jakubnowicki June 10, 2025 14:30
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vituri vituri merged commit 4572c0f into connect-user-metrics Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants