Support custom commands #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evg-tso
requested changes
Dec 28, 2022
Member
evg-tso
left a comment
evg-tso
left a comment
There was a problem hiding this comment.
I know the README is lacking, but please add the proposed :ketu.source/consumer-commands-chan field under the consumer-source-options section.
Consider adding a usage guide with this addition, what types of items are expected to be in the channel, etc.
yaronthurm
force-pushed
the
support-custom-commands
branch
from
a27a162 to
356d01f
Compare
yaronthurm
force-pushed
the
support-custom-commands
branch
3 times, most recently
from
e307ff6 to
313c38c
Compare
yaronthurm
force-pushed
the
support-custom-commands
branch
from
313c38c to
a6ab055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for running custom logic from within the consumer poll loop.
This can be useful in cases when we need to invoke functions on the underlying kafka consumer (e.g.
pause), as the consumer has protection against concurrent invocations from different threads and will throw an exception.Related to #13