Fixes #1983: WorldData cleared too early when still needed. #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube analysis reported 2 issues:
Watch the comments in this conversation to review them. |
| } | ||
|
|
||
| @EventHandler | ||
| private void serverStopped( final FMLServerStoppedEvent event ) |
There was a problem hiding this comment.
Remove the unused method parameter(s) "event". 
Private method 'serverStopped' is never used.
There was a problem hiding this comment.
I dont think that annotated methods should be major problems
yueh
added a commit
that referenced
this pull request
Nov 16, 2015
Fixes #1983: WorldData cleared too early when still needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WorldDatainstance is removed too early during the server stop and not once the server is actually stopped.This results in interdimensional networks to not be saved correctly as they no longer can access the
StorageDatato determine their grid.Moved the cleanup to
FMLServerStoppedEventstage and extended the interface forIWorldDatato contain a method this stage.