Skip to content

Commit

Permalink
Require nodejs 10 and update build docs (dotnet#4805)
Browse files Browse the repository at this point in the history
  • Loading branch information
JamesNK authored Dec 13, 2018
1 parent 6d2f248 commit 35d8ee6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/BuildFromSource.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Building ASP.NET Core on Windows requires:
* Visual Studio 2017. <https://visualstudio.com>
* Git. <https://git-scm.org>
* (Optional) some optional components, like the SignalR Java client, may require
* NodeJS <https://nodejs.org>
* NodeJS. LTS version of 10.14.2 or newer recommended <https://nodejs.org>
* Java Development Kit 10 or newer. Either:
* OpenJDK <http://jdk.java.net/10/>
* Oracle's JDK <https://www.oracle.com/technetwork/java/javase/downloads/index.html>
Expand All @@ -32,7 +32,7 @@ Building ASP.NET Core on macOS or Linux requires:
* At least 10 GB of disk space and a good internet connection (our build scripts download a lot of tools and dependencies)
* Git <https://git-scm.org>
* (Optional) some optional components, like the SignalR Java client, may require
* NodeJS <https://nodejs.org>
* NodeJS. LTS version of 10.14.2 or newer recommended <https://nodejs.org>
* Java Development Kit 10 or newer. Either:
* OpenJDK <http://jdk.java.net/10/>
* Oracle's JDK <https://www.oracle.com/technetwork/java/javase/downloads/index.html>
Expand Down
2 changes: 1 addition & 1 deletion korebuild.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"msbuildType": "full",
"toolsets": {
"nodejs": {
"minVersion": "8.0",
"minVersion": "10.0",
"required": true
},
"visualstudio": {
Expand Down

0 comments on commit 35d8ee6

Please sign in to comment.