Create a login page that redirects to the browser: #1237#1336
Create a login page that redirects to the browser: #1237#1336Shafaatul-Islam wants to merge 28 commits intomasterfrom
Conversation
Shafaatul-Islam
changed the title
Shafaatul-Islam
changed the title
LouisPhilippeHeon
left a comment
LouisPhilippeHeon
left a comment
There was a problem hiding this comment.
Comments in bulk:
- Buttons should have icons
- We should add ÉTS's logo on top of the screen (instead of AppETS)
- Login button should be bigger and styled differently
- We should make a gradient for the background color
- The loading indicator should be directly on the login button
https://github.com/ApplETS/Notre-Dame into feature/1237-login-page-that-redirects-to-the-browser
https://github.com/ApplETS/Notre-Dame into feature/1237-login-page-that-redirects-to-the-browser
|
| Future authenticate() async { | ||
| AuthenticationResult? token; | ||
| int attempts = 0; | ||
| const maxAttempts = 3; |
There was a problem hiding this comment.
We should only make one attempt. We used to do 3 because the user had no way to retry. So for example if the user closed the browser page, it would re-open automatically. Now that we have a way button to retry, this behavior is not desirable.
There was a problem hiding this comment.
The linux folder should be deleted, as we don't target that platform.
There was a problem hiding this comment.
The macos folder should be deleted, as we don't target that platform.
There was a problem hiding this comment.
There should be a test for the view itself (test that the login button opens the webpage, test that the faq button works).
|
2 participants
closes: #1237
📖 Description
Created a new page with a login button and FAQ button. At startup, it will redirect to this new page instead of sending the user to the authentication page.
🧪 How Has This Been Tested?
-Flutter analyze
-All unit tests
-On-device tests
☑️ Checklist before requesting a review
version: Major,version: Minororversion: Patch.🖼️ Screenshots (if useful):