Add maxSDK capability + semantic version filtering #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikrishna321
approved these changes
Mar 6, 2023
|
@JoelWhitney Can you try running ios integration test from main. It's failing after this PR. |
|
@saikrishna321 PR opened to address the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
appium:maxSDKcapability. Combined withappium:minSDKyou will be able to filter devices to a given range.Also, when working on #576, I noticed that the
minSDKfilter only worked if thedevice.sdkcould be cast to a float. For devices with semantic versioning, such as16.1.2, this filter didn't work. Usingsemver, you can now filter devices that have semantic versioning.