Feature: Add CLI argument for maxSessions #580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I've begun running more tests concurrently, I have started to see significant performance degradation with Appium where things will slow down and sessions will start to have subprocesses killed on host machine resulting in test failures. Adding this CLI argument to device-farm allows the user to limit the number of tests running at a time to make sure they are getting the bests performance based on the hardware that they are running tests on.
Selenium Grid also provides a
--max-sessions
CLI argument for limiting the number of sessions that can be run concurrently.Note: I also added an
Active session
label in the web app, which was mainly a convenient way to test that the implementation was working -- I can remove this if you'd likeUsage
appium server -ka 800 --use-plugins=device-farm,appium-dashboard -pa /wd/hub --plugin-device-farm-platform=android --plugin-device-farm-max-sessions=8
TODO