Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Device logs and profiling #1177

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Fix Device logs and profiling #1177

merged 1 commit into from
Jun 14, 2024

Conversation

SrinivasanTarget
Copy link
Member

@SrinivasanTarget SrinivasanTarget commented Jun 14, 2024

I see the session is getting removed from session manager even before the test completes or well before the deletesession gets called so switched from req method condition to command Name

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appium-device-farm-bre4 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 6:05pm

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for voluble-wisp-b266e5 failed.

Name Link
🔨 Latest commit 892132a
🔍 Latest deploy log https://app.netlify.com/sites/voluble-wisp-b266e5/deploys/666c8628619dfe000888ba42

@SrinivasanTarget SrinivasanTarget changed the title Fix App logs and profiling Fix Device logs and profiling Jun 14, 2024
@sudharsan-selvaraj
Copy link
Collaborator

sudharsan-selvaraj commented Jun 14, 2024

Nice catch on the delete session part. Looks great bro!

@SrinivasanTarget SrinivasanTarget merged commit cad29c9 into main Jun 14, 2024
8 of 15 checks passed
@SrinivasanTarget SrinivasanTarget deleted the fixLogsAndProfiling branch June 14, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants