Skip to content

Conversation

prabhu
Copy link
Contributor

@prabhu prabhu commented Mar 29, 2025

No description provided.

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @prabhu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the version of the chen project to 2.3.6 and upgrades the Java version in the Dockerfile to Java 24. It also updates the Gradle version in the Dockerfile.

Highlights

  • Version Update: The project version has been bumped from 2.3.5 to 2.3.6 in build.sbt, codemeta.json, meta.yaml, and pyproject.toml.
  • Java Version Upgrade: The Dockerfile now uses Java 24 instead of Java 23.0.2-tem.
  • Gradle Version Upgrade: The Dockerfile now uses Gradle 8.13 instead of Gradle 8.12.1.

Changelog

Click here to see the changelog
  • build.sbt
    • Updated project version from 2.3.5 to 2.3.6 on line 3.
  • ci/Dockerfile
    • Upgraded JAVA_VERSION from 23.0.2-tem to 24-tem on line 14.
    • Upgraded GRADLE_VERSION from 8.12.1 to 8.13 on line 16.
  • codemeta.json
    • Updated project version from 2.3.5 to 2.3.6 on line 10.
  • meta.yaml
    • Updated project version from 2.3.5 to 2.3.6 on line 1.
  • pyproject.toml
    • Updated project version from 2.3.5 to 2.3.6 on line 3.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A version bumps, a number's flight,
From point to point, with all its might.
Java ascends, a newer stage,
Gradle follows, turning a page.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the version of the chen project to 2.3.6 and updates the Java and Gradle versions in the Dockerfile. The changes seem straightforward and necessary for keeping the project up-to-date.

Merge Readiness

The pull request appears to be ready for merging. The changes are simple version updates and should not introduce any new issues. However, I am unable to directly approve the pull request, and it should be reviewed and approved by others before merging.

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu
Copy link
Contributor Author

prabhu commented Mar 29, 2025

Couple of LombokTests are failing under java 24.

[error] Failed tests:
[error] 	io.appthreat.javasrc2cpg.querying.LombokTests
[error] 	io.appthreat.javasrc2cpg.querying.LombokTypesOnlyTests
 - should delombok the source correctly *** FAILED ***
[info]   Expected single getValue method but got List() (LombokTests.scala:30)
[info] - should not give the delomboked filename
[info] - source with lombok annotations should have correct type information *** FAILED ***
[info]   "Foo.getFirstName:[<unresolvedSignature>(0])" was not equal to "Foo.getFirstName:[java.lang.String(])" (LombokTests.scala:73)

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu marked this pull request as draft July 5, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant