Squashed insights page #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 feat(Metas): add support for insights dashboard link and feature flag
… main title to '__INSIGHTS_PAGE_TITLE'
🔥 chore(PageHeader.tsx): clean up and organize imports in VideoPageHeader component
🎨 style(Insights): refactor InsightsPageContent layout for better organization
🔄 chore(Content.tsx): update import to use Collection instead of ObservationsList
🚀 feat(Insights): implement FormProvider for managing form state 🚀 feat(Insights): create Insight component for displaying insights 🚀 feat(Insights): add InsightForm component for editing insights 🚀 feat(Insights): integrate InsightsDrawer with Insight components 🎨 style(Widgets.tsx): refactor Widgets component to use styled-components 🔨 chore(Widgets.tsx): update Widgets component to use LG component and i18n translation
…glish and Italian 🚀 feat(ActionBar): add floating container for ActionBar with create insight button 🚀 feat(Content): add tooltip and IconButton to open InsightsDrawer 🚀 feat(Insight): add Divider component before each Insight accordion 🚀 feat(InsightContext): create InsightContext for managing InsightsDrawer visibility 🔧 fix(InsightForm.tsx): add 'isPrimary' prop to edit button 🔧 fix(InsightForm.tsx): adjust layout and add comments for future improvements 🔧 fix(InsightsDrawer.tsx): add close button with tooltip and adjust layout 🔧 fix(index.tsx): wrap InsightsPageContent with InsightContextProvider
…English and Italian locales 🚀 feat(InsightForm): add delete and undo buttons functionality to InsightForm
🔧 refactor(InsightsDrawer.tsx): add conditional rendering based on values.id
Insights-page-collection
…istency 🚀 feat(schema.ts): add new endpoint for retrieving observations of a specific campaign 🔧 chore(schema.ts): fix typo in endpoint path for observations of a campaign 🔧 fix(schema.ts): change all single quotes to double quotes for consistency 🔧 fix(schema.ts): fix inconsistent quotes for object keys in schema definition 🔨 refactor(schema.ts): update string literals to use double quotes instead of single quotes 🔨 refactor(schema.ts): update enum values to use double quotes instead of single quotes 🔧 fix(schema.ts): change single quotes to double quotes for consistency 🔧 fix(schema.ts): change single quotes to double quotes for consistency 🔧 fix(schema.ts): change all single quotes to double quotes for consistency 🚀 feat(schema.ts): add new endpoint for getting campaign observations by ID 🔨 refactor(schema.ts): change single quotes to double quotes for JSON keys 🔧 chore(schema.ts): update JSON key quotes to be consistent with codebase conventions 🔨 refactor(schema.ts): change all single quotes to double quotes for consistency 🔨 refactor(schema.ts): change all components object keys to use double quotes 🔨 refactor(schema.ts): change single quotes to double quotes for consistency 🔥 chore(schema.ts): remove unnecessary comments and whitespace in schema file 🚀 feat(api): add new query to fetch campaigns by cid observations 🔨 refactor(api): update ObservationCard component to display observation details
…uot; for observation quotes
🚀 feat(observation): open lightbox with observation details on click
Observation, UseCase, and Video types 🔧 fix(Lightbox.tsx): remove unused import of DownloadIcon component 🔧 fix(ObservationCard.tsx): update onClick event handler to remove unused parameter 🔧 fix(index.tsx): update observations data structure in Collection component to include detailed information for each observation
Observation card
The code changes in `schema.ts` modify the `components` interface to include additional properties (`uploaderId`, `mediaId`, `deviceType`, and `usecaseTitle`) in the `observations` array. This change provides more detailed information for each observation. Based on the recent repository commits, it seems that the team has been working on various improvements and fixes related to the observation cards, lightbox, and schema.
fix(CampaignCard): reduce hooks drilling and fix onClick issues feat(add: route insights) feat(add page header button go to insights) feat: add base page insights 🔀 chore(translation): update translation for "Go to insights" button 🚀 feat(Metas): add support for insights dashboard link and feature flag 🔧 fix(PageHeader.tsx): remove unused variables and conditions, update main title to '__INSIGHTS_PAGE_TITLE' 🔨 refactor(PageHeader.tsx): remove unused imports and styled components 🔥 chore(PageHeader.tsx): clean up and organize imports in VideoPageHeader component 🚀 feat(Insights): add InsightsDrawer component and related components 🎨 style(Insights): refactor InsightsPageContent layout for better organization 🚀 feat(Collection.tsx): add Collection component for insights page 🔄 chore(Content.tsx): update import to use Collection instead of ObservationsList 🔄 refactor(Content.tsx): rename ObservationsList component to Collection 🚀 feat(Insights): add ActionBar component for creating new insights 🚀 feat(Insights): implement FormProvider for managing form state 🚀 feat(Insights): create Insight component for displaying insights 🚀 feat(Insights): add InsightForm component for editing insights 🚀 feat(Insights): integrate InsightsDrawer with Insight components 🎨 style(Widgets.tsx): refactor Widgets component to use styled-components 🔨 chore(Widgets.tsx): update Widgets component to use LG component and i18n translation 🔧 chore(translation): update translation keys for Insights page in English and Italian 🚀 feat(ActionBar): add floating container for ActionBar with create insight button 🚀 feat(Content): add tooltip and IconButton to open InsightsDrawer 🚀 feat(Insight): add Divider component before each Insight accordion 🚀 feat(InsightContext): create InsightContext for managing InsightsDrawer visibility 🔧 fix(InsightForm.tsx): add 'isPrimary' prop to edit button 🔧 fix(InsightForm.tsx): adjust layout and add comments for future improvements 🔧 fix(InsightsDrawer.tsx): add close button with tooltip and adjust layout 🔧 fix(index.tsx): wrap InsightsPageContent with InsightContextProvider 🔀 chore(translation): add delete and undo buttons to insight form in English and Italian locales 🚀 feat(InsightForm): add delete and undo buttons functionality to InsightForm 🔧 refactor(ActionBar.tsx): update setValues in ActionBar component 🔧 refactor(InsightsDrawer.tsx): add conditional rendering based on values.id wip: test card interaction wip: test card and cluster interaction fix: try to fix eccessive rerendering refactor: refactor form and drawer logic refactor: optimize rendering of ClusterCard and ObservationCard components wip: fake data 🔨 refactor(schema.ts): update all paths to use double quotes for consistency 🚀 feat(schema.ts): add new endpoint for retrieving observations of a specific campaign 🔧 chore(schema.ts): fix typo in endpoint path for observations of a campaign 🔧 fix(schema.ts): change all single quotes to double quotes for consistency 🔧 fix(schema.ts): fix inconsistent quotes for object keys in schema definition 🔨 refactor(schema.ts): update string literals to use double quotes instead of single quotes 🔨 refactor(schema.ts): update enum values to use double quotes instead of single quotes 🔧 fix(schema.ts): change single quotes to double quotes for consistency 🔧 fix(schema.ts): change single quotes to double quotes for consistency 🔧 fix(schema.ts): change all single quotes to double quotes for consistency 🚀 feat(schema.ts): add new endpoint for getting campaign observations by ID 🔨 refactor(schema.ts): change single quotes to double quotes for JSON keys 🔧 chore(schema.ts): update JSON key quotes to be consistent with codebase conventions 🔨 refactor(schema.ts): change all single quotes to double quotes for consistency 🔨 refactor(schema.ts): change all components object keys to use double quotes 🔨 refactor(schema.ts): change single quotes to double quotes for consistency 🔥 chore(schema.ts): remove unnecessary comments and whitespace in schema file 🚀 feat(api): add new query to fetch campaigns by cid observations 🔨 refactor(api): update ObservationCard component to display observation details 🔧 fix(ObservationCard.tsx): replace double quotes with HTML entity " for observation quotes 🌐 feat(translation): add label for observation selection button 🚀 feat(observation): open lightbox with observation details on click 🔧 fix(ClusterCard.tsx): update ClusterCardProps interface to include Observation, UseCase, and Video types 🔧 fix(Lightbox.tsx): remove unused import of DownloadIcon component 🔧 fix(ObservationCard.tsx): update onClick event handler to remove unused parameter 🔧 fix(index.tsx): update observations data structure in Collection component to include detailed information for each observation feat(lightbox): update content chore: add uuid package wip: accordion visualization for grapes refactor: optimize rendering of ClusterCard and ObservationCard components feat(schema): add detailed information to observations in components The code changes in `schema.ts` modify the `components` interface to include additional properties (`uploaderId`, `mediaId`, `deviceType`, and `usecaseTitle`) in the `observations` array. This change provides more detailed information for each observation. Based on the recent repository commits, it seems that the team has been working on various improvements and fixes related to the observation cards, lightbox, and schema. feat: add ObservationCard from parent branch fix(log): remove console log fix(ObsCard): fixed click on lightbox cta 🎨 style(ObservationCard.tsx): add Ellipsis component and style Tag and Anchor components 🔧 chore(ObservationCard.tsx): remove unused MouseEventHandler import 🔧 fix(ObservationCard.tsx): filter out 'title' tag from tags array and use 'title' tag value for card header title chore: update api fix: grid rows height wip: collection section title and toggle logic 🔨 refactor(translation.json): add missing translation keys for lightbox labels 🚀 feat(Lightbox.tsx): implement copy link functionality and display observation tags and notes 🔧 chore(ObservationCard.tsx): move getDeviceIcon function to Lightbox file wip: usecase section feat: Add Grape observations to InsightFormValues 🔨 refactor(Lightbox.tsx): remove duplicate video fetching logic 🔥 refactor(ObservationCard.tsx): remove unused video fetching logic and memoization 🚀 feat(InsightsDrawer.tsx): add NewInsight component for creating new insights 🆕 feat(NewInsight.tsx): create NewInsight component for adding new insights 🔨 refactor(InsightsDrawer.tsx): rename NewInsight component to NewInsightForm 🔨 refactor(NewInsight.tsx): convert NewInsight component to NewInsightForm refactor: Rename collection title and add use case grouping 🔧 chore(InsightForm.tsx): add resetForm function to undo button onClick event feat: Add Grape observations to InsightFormValues 🎨 style(Content.tsx): add styled-components for Col component styling in InsightsPageContent 🔨 refactor(InsightsDrawer.tsx): update InsightsDrawer component to fetch insights dynamically based on campaignId 🚀 feat(InsightsDrawer.tsx): add loading skeleton while fetching insights data 🔨 refactor(FormProvider.tsx): update InsightFormValues type to match API response structure refactor: Improve AccordionSection component in Insights Collection 🔨 refactor(schema.ts): update all paths to use double quotes for consistency 🔧 chore(schema.ts): fix typo in 'existent' to 'existing' in comments 🔧 fix(schema.ts): change all single quotes to double quotes for consistency 🔧 fix(schema.ts): update object keys to use double quotes for consistency 🔧 fix(schema.ts): update enum values to use double quotes instead of single quotes 🔧 fix(schema.ts): update enum values to use double quotes consistently throughout the file 🔧 fix(schema.ts): change single quotes to double quotes for consistency 🔧 fix(schema.ts): change single quotes to double quotes for consistency 🔨 refactor(schema.ts): change single quotes to double quotes for consistency 🔨 refactor(schema.ts): change object key quotes to double quotes for consistency 🔨 refactor(schema.ts): change single quotes to double quotes for consistency 🔨 refactor(schema.ts): change single quotes to double quotes for consistency 🔨 refactor(schema.ts): change all single quotes to double quotes for consistency 🔨 refactor(schema.ts): change all object keys to use double quotes for consistency 🔨 refactor(schema.ts): change single quotes to double quotes for consistency 🔥 chore(schema.ts): remove unnecessary comments and whitespace changes 🔨 refactor(api): simplify status comments in API response types 🌐 chore(translation): add and update translation keys for insight form 🚀 feat(FormProvider): add support for creating and updating insights 🔨 refactor(InsightForm.tsx): restructure form layout and add support for severity tags 🔥 remove(NewInsight.tsx): delete unused NewInsightForm component 🚀 feat(ObservationForm.tsx): export RadioTag styled component for reusability 🔇 chore(InsightsDrawer.tsx): remove console.log statement for 'values' 🔧 refactor(InsightsDrawer.tsx): simplify condition for resetting form in onClick event 🔧 fix(InsightForm.tsx): add resetForm function to handle form reset on button click 🔧 fix(translation.json): add missing translation for observation deselect button 🔧 fix(translation.json): add missing translation for observation deselected toast 🔧 fix(translation.json): add missing translation for observation selected toast 🔧 fix(ActionBar.tsx): update z-index value using theme levels front 🔧 fix(Lightbox.tsx): add missing import for useFormikContext 🔧 fix(Lightbox.tsx): add InsightFormValues type import 🔧 fix(Lightbox.tsx): add logic to handle observation selection/deselection and display toast messages 🔨 refactor(Insight.tsx): remove unused SM component and observation rendering 🚀 feat(Insight.tsx): update onClick handler to set values with additional properties feat: added handle delete insight @iDome89 added severities id mapping refactor: Improve AccordionSection component in Insights Collection added invalidate tags added reemaining api tags and mapped severities 🔨 refactor(InsightForm.tsx): optimize imports for useGetCampaignsByCidVideoTagsQuery function fix: Filter out already selected observations in AccordionSection component refactor: Optimize GrapeCheckbox component in Insights Collection chore: remove unused vars 🔄 refactor(translation): update missing translation keys in English and Italian 🔨 refactor(ObservationCard.tsx): improve tag display and add missing translation 🔧 chore(InsightForm.tsx): remove unnecessary blank line before return statement refactor: move and extract drawer components chore: update @zendeskgarden/svg-icons to version 7.2.0 feat: add tooltip and notification for publishing/unpublishing insights GroupByToggle with buttons refactor: Update GroupByToggle component to use context for state management feat: add GroupByToggle to SectionTitle component 🔥 refactor(Collection/index.tsx): remove unused imports and components 📝 chore(translation.json): add missing translation for "Show all" in English and Italian 🔀 chore(translation.json): remove unused translation keys for insight form buttons 🔨 refactor(InsightForm.tsx): remove unnecessary severity mapping logic 🔥 refactor(InsightForm.tsx): simplify rendering of severity tags in InsightForm 🐛 fix(InsightForm.tsx): display error message for observations field validation 🎨 update(Lightbox.tsx): change 'desktop' to 'PC' and add 'other' case for device icons 🔧 refactor(ObservationCard.tsx): conditionally render device icon and usecase title refactor: move insightform change some translations feat: drawer/page style refactor: update detailcontainer title and remove unused code feat: drawer data, behaviour and style. WIP widgets wip widgets ux WIP wip widget ux campaigns WIP hooks definition WIP need to fix severity distribution wip need to fix last widget added graph + fixed labels for widgets added utils to define max severity fixed widgets hooks fix: added missing widget labels 🔥 refactor(InsightAccordion.tsx): remove unused Separator import 🔨 refactor(schema.ts): update video object in components and Insight schema 🔨 refactor(api/index.ts): update Insight type in GetCampaignsByCidInsightsApiResponse 🔨 refactor(ObservationCard.tsx): remove extra whitespace 🔨 refactor(FormProvider.tsx): update InsightFormValues type definition 🔧 fix(Lightbox.tsx): update device comparison to be case-insensitive 🔧 fix(InsightAccordion.tsx): set deviceType based on video's deviceType 🚀 feat(ObservationCard.tsx): display uploaderId in ObservationCard if greater than 0
delete confirmation modal + ux fixes
Co-authored-by: iDome89 <iDome89@users.noreply.github.com>
Insisghts navigation
Good insights fixes
fix: import the `getDeviceIcon` function from the `BugDetail/Meta` module
marcbon
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.