-
Notifications
You must be signed in to change notification settings - Fork 1
Check-validation #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Check-validation #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r in English and Italian locales
…-system and app/theme respectively ✨ feat(Drawer/index.tsx): add CustomStatusForm component to Drawer.Body 🔥 chore(Drawer/index.tsx): remove unused import Button from unguess-design-system 🔧 fix(Drawer/index.tsx): add isBasic prop to Button component in Drawer.FooterItem
…nction to retrieve custom status phase name 🔀 diff --git a/src/pages/Bug/Drawer/getCustomStatusPhaseName.ts b/src/pages/Bug/Drawer/getCustomStatusPhaseName.ts 🆕 new file mode 100644 🔢 index 00000000..188cd63b 📄 --- /dev/null 📄 +++ b/src/pages/Bug/Drawer/getCustomStatusPhaseName.ts 📝 Add getCustomStatusPhaseName function to retrieve custom status phase name. The function takes in a phase object and a translation function (t) and returns the corresponding custom status phase name based on the phase id. If the phase id is 1, it returns the translation of '__BUGS_PAGE_CUSTOM_STATUS_DRAWER_PHASE_1_NAME', and if the phase id is 2, it returns the translation of '__BUGS
This commit adds the `CustomStatusForm` component to the project. The component is responsible for rendering a form to manage custom statuses for a campaign. It includes functionality to fetch custom statuses from the API, split them by phase, and display them in the form. The form allows users to create, edit, and delete custom statuses.
…options 🔥 chore(DotsMenu.tsx): remove commented out code and newline at end of file
✨ feat(CustomStatusForm.tsx): add functionality to update custom status name
…SimpleState' interface
✨ feat(BugStateDropdown.tsx): refactor custom status options rendering and selection logic
The Circle component is added to the Bug Drawer to display a colored circle. It is styled using styled-components and takes a color prop to determine the color of the circle. The component is used to represent a status indicator in the Bug Drawer.
…ed component ✨ feat(CustomStatusForm.tsx): add useEffect hook to update custom status with new custom statuses with is_default === 0
✨ feat(DotsMenu.tsx): add dispatch and useSelector hooks for Redux state management
✨ feat(CustomStatusDrawer): close drawer on reset button click
…g customStatus variable in useAppSelector ✨ feat(Drawer/index.tsx): add functionality to delete and patch custom statuses
🔧 fix(Drawer/index.tsx): fix incorrect variable name in deleteCustomStatus array 🔧 fix(Drawer/index.tsx): fix incorrect type in deleteCustomStatus array 🔧 fix(Drawer/index.tsx): fix incorrect type in patchCustomStatus array 🔧 fix(Drawer/index.tsx): fix incorrect type in deleteCustomStatusUsed array 🔧 fix(Drawer/index.tsx): fix incorrect type in deleteCustomStatusUnused array 🔧 fix(Drawer/index.tsx): fix incorrect type in deleteCustomStatusUsed filter 🔧 fix(Drawer/index.tsx): fix incorrect type in deleteCustomStatusUnused filter 🔧 fix(Drawer/index.tsx): fix incorrect type in deleteCustomStatusUsed find 🔧 fix(Drawer/index.tsx): fix incorrect type in deleteCustomStatusUnused find 🔧 fix
fetures: added modals for custom status
…tialSimpleState interface 🔧 fix(bugsPageSlice.ts): add setCustomStatusDrawerTouched reducer to bugPageSlice
…nd modals ✨ feat(Drawer/index.tsx): add confirmation modal for closing drawer when changes are made ✨ feat(Drawer/index.tsx): add migration modal for custom status migration
… touched ✨ feat(CustomStatusForm.tsx): add setCustomStatusDrawerTouched action to dispatch when form is submitted
…ctionality ✨ feat(ClosingDrawerConfirmationModal/index.tsx): add functionality to quit button
✨ feat(BugStateDropdown.tsx): add BugStateDropdownMenu and BugStateDropdownItem components
…essary code ✨ feat(StatusValidationMessage.tsx): add comments to clarify code functionality
…er prop in cancel Button component
…BUGS_PAGE_CUSTOM_STATUS_DRAWER_BODY_DESCRIPTION
…talian translation
…IL_SIBLINGS_SHOW_MORE_many" key
…y/unguess-design-system' 🐛 fix(mapBugsToTableData.tsx): add textTransform and fontWeight styles to custom status tag 🐛 fix(mapBugsToTableData.tsx): fix indentation in borderColor assignment
…sage ✨ feat(translation.json): add validation message for maximum length of custom status name 🐛 fix(translation.json): update error toast message for invalid input fields 🌐 chore(translation.json): update Italian translation for custom status messages
…Styles from @zendeskgarden/react-theming 🔧 fix(BugStateDropdown.tsx): add styling for disabled ManageItem component
…E_CUSTOM_STATUS_DRAWER_CONFIRM_BUTTON"
…ace.sm for width, height, min-width, and min-height
…mStatusUsed ✨ feat(MigrationModal/index.tsx): add support for calculating bugs count for deleteCustomStatusUsed
…t into check-validation
…ustomStatusUsed paragraph
…tion modal
The translation for the text "Before confirming and deleting, choose how to handle {{custom_statuses_num}} bugs in this campaign associated with these status:" was updated in both the English and Italian translation files. The word "status" was changed to "statuses" to reflect the plural form correctly.
….id instead of item.name
🔧 chore(apiTags.ts): update invalidatesTags and providesTags for API endpoints
cannarocks
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation for custom status drawer + various improvements