Skip to content

Sentiment & Insights fixes #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 14, 2023
Merged

Sentiment & Insights fixes #665

merged 3 commits into from
Sep 14, 2023

Conversation

@marcbon
Copy link
Collaborator

@marcbon marcbon commented Sep 13, 2023 •
edited
Loading

Lista:

  • L'ordinamento deve essere dal più negativo al più positivo
  • Tra un UC e un altro c'è uno spazio di 12px
  • A mobile label "sentiment" dovrebbe sparire

Commenti:

  • Placeholder da cambiare, per il momento inserire:
  1. ENG: Here you can input your notes. Click on the edit button to make changes. 2. ITA: Qui puoi appuntare le tue note. Clicca sul bottone di modifica per editare.

@marcbon
🔧 chore(Item.tsx): change margin-top to margin-bottom in ListItemWrapper
a126315
@marcbon
🐛 fix(SentimentList/index.tsx): fix order of sentiments to be ascendi…
ff389fb 
…ng instead of descending

✨ feat(SentimentList/index.tsx): add media query to hide StyledLabel component on xl breakpoint
@marcbon
🌍 chore(translation.json): update placeholder text for comment card i…
da7338c 
…n English and Italian locales
@cannarocks cannarocks merged commit 461f6b0 into develop Sep 14, 2023
@cannarocks cannarocks deleted the sentiment-insight-fixes branch September 14, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cannarocks cannarocks cannarocks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcbon @cannarocks