Skip to content

fix(page-header): return project link only if user can reach it #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix(page-header): return project link only if user can reach it #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions src/pages/Bug/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
GetCampaignsByCidApiResponse,
GetCampaignsByCidBugsAndBidApiResponse,
useGetCampaignsByCidQuery,
useGetProjectsByPidQuery,
} from 'src/features/api';
import { ReactComponent as ShareIcon } from 'src/assets/icons/share-stroke.svg';
import { useLocalizeRoute } from 'src/hooks/useLocalizedRoute';
Expand All @@ -34,15 +35,36 @@ const BreadCrumbs = ({
campaign: GetCampaignsByCidApiResponse;
}) => {
const { t } = useTranslation();

const projectRoute = useLocalizeRoute(`projects/${campaign.project.id}`);
const campaignRoute = useLocalizeRoute(`campaigns/${campaign.id}`);
const bugsRoute = useLocalizeRoute(`campaigns/${campaign.id}/bugs`);

const {
currentData: project,
isLoading,
isFetching,
} = useGetProjectsByPidQuery({
pid: campaign.project.id.toString(),
});

if (isLoading || isFetching) {
return <Skeleton width="200px" height="12px" />;
}

return (
<PageHeader.Breadcrumbs>
<Link to={useLocalizeRoute(`projects/${campaign.project.id}`)}>
<Anchor id="breadcrumb-parent">{campaign.project.name}</Anchor>
</Link>
<Link to={useLocalizeRoute(`campaigns/${campaign.id}`)}>
{project ? (
<Link to={projectRoute}>
<Anchor id="breadcrumb-parent">{project.name}</Anchor>
</Link>
) : (
campaign.project.name
)}
<Link to={campaignRoute}>
<Anchor>{campaign.customer_title}</Anchor>
</Link>
<Link to={useLocalizeRoute(`campaigns/${campaign.id}/bugs`)}>
<Link to={bugsRoute}>
<Anchor>{t('__PAGE_TITLE_BUGS_COLLECTION')}</Anchor>
</Link>
</PageHeader.Breadcrumbs>
Expand Down
11 changes: 8 additions & 3 deletions src/pages/Bugs/PageHeader/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,14 @@ const BugsPageHeader = ({ campaignId }: { campaignId: number }) => {
<LayoutWrapper isNotBoxed>
<PageHeader>
<PageHeader.Breadcrumbs>
<Link to={project.route}>
<Anchor id="breadcrumb-parent">{project.name}</Anchor>
</Link>
{project.hasAccess ? (
<Link to={project.route}>
<Anchor id="breadcrumb-parent">{project.name}</Anchor>
</Link>
) : (
project.name
)}

<Link to={getLocalizeoFirstLevelDashboardRoute(campaignId)}>
<Anchor>{campaign.customer_title}</Anchor>
</Link>
Expand Down